Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 10958052: Removed unnecessary returning by reference. (Closed)

Created:
8 years, 3 months ago by Vitaly Buka (NO REVIEWS)
Modified:
8 years, 3 months ago
Reviewers:
gene
CC:
chromium-reviews
Visibility:
Public.

Description

Removed unnecessary returning by reference to simplify code. BUG=137129 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=158200

Patch Set 1 : #

Patch Set 2 : #

Total comments: 1

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -66 lines) Patch
M chrome/service/cloud_print/cloud_print_proxy.cc View 1 2 5 chunks +10 lines, -14 lines 0 comments Download
M chrome/service/cloud_print/connector_settings.cc View 1 2 3 chunks +11 lines, -12 lines 0 comments Download
M chrome/service/service_process.cc View 1 2 chunks +5 lines, -15 lines 0 comments Download
M chrome/service/service_process_prefs.h View 1 2 3 2 chunks +11 lines, -7 lines 0 comments Download
M chrome/service/service_process_prefs.cc View 1 2 3 2 chunks +33 lines, -12 lines 0 comments Download
M chrome/service/service_process_prefs_unittest.cc View 1 2 3 4 1 chunk +2 lines, -6 lines 0 comments Download

Messages

Total messages: 19 (0 generated)
Vitaly Buka (NO REVIEWS)
8 years, 3 months ago (2012-09-21 21:50:18 UTC) #1
Vitaly Buka (NO REVIEWS)
On 2012/09/21 21:50:18, Vitaly Buka wrote: Done.
8 years, 3 months ago (2012-09-21 22:49:57 UTC) #2
gene
lgtm https://chromiumcodereview.appspot.com/10958052/diff/5002/chrome/service/cloud_print/connector_settings.cc File chrome/service/cloud_print/connector_settings.cc (right): https://chromiumcodereview.appspot.com/10958052/diff/5002/chrome/service/cloud_print/connector_settings.cc#newcode55 chrome/service/cloud_print/connector_settings.cc:55: remove_missing_printers_ = source.remove_missing_printers(); this is from previous CL
8 years, 3 months ago (2012-09-21 22:57:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/10958052/8002
8 years, 3 months ago (2012-09-22 02:16:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/10958052/8002
8 years, 3 months ago (2012-09-22 02:16:35 UTC) #5
commit-bot: I haz the power
Retried try job too often for step(s) build
8 years, 3 months ago (2012-09-22 02:23:16 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/10958052/16001
8 years, 3 months ago (2012-09-22 02:37:37 UTC) #7
commit-bot: I haz the power
Retried try job too often for step(s) crypto_unittests, unit_tests, cacheinvalidation_unittests, remoting_unittests, jingle_unittests, nacl_integration, ipc_tests, interactive_ui_tests, ...
8 years, 3 months ago (2012-09-22 02:43:13 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/10958052/16001
8 years, 3 months ago (2012-09-22 07:31:04 UTC) #9
commit-bot: I haz the power
Retried try job too often for step(s) compile
8 years, 3 months ago (2012-09-22 07:36:27 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/10958052/13025
8 years, 3 months ago (2012-09-22 08:06:10 UTC) #11
commit-bot: I haz the power
Retried try job too often for step(s) compile
8 years, 3 months ago (2012-09-22 08:11:02 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/10958052/13025
8 years, 3 months ago (2012-09-22 20:07:38 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/10958052/13029
8 years, 3 months ago (2012-09-22 22:57:15 UTC) #14
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build. Your ...
8 years, 3 months ago (2012-09-22 23:22:45 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/10958052/13035
8 years, 3 months ago (2012-09-22 23:48:32 UTC) #16
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build. Your ...
8 years, 3 months ago (2012-09-23 00:25:57 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/10958052/6057
8 years, 3 months ago (2012-09-23 00:46:28 UTC) #18
commit-bot: I haz the power
8 years, 3 months ago (2012-09-23 03:51:42 UTC) #19
Change committed as 158200

Powered by Google App Engine
This is Rietveld 408576698