Issue 10958032: Merged HostQuotaCallback into QuotaCallback

Issue 10958032: Merged HostQuotaCallback into QuotaCallback (Closed)

Created:
8 years, 3 months ago by calvinlo

Modified:
8 years, 2 months ago

Reviewers:
kinuko, Evan Stade

CC:
chromium-reviews, darin-cc_chromium.org, tzik

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Merged HostQuotaCallback into QuotaCallback BUG=148900 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=158547

Patch Set 2 : Kinuko Review #1 #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -38 lines)			Patch
M	chrome/browser/ui/webui/quota_internals_proxy.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/webui/quota_internals_proxy.cc	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	webkit/quota/quota_manager.h	View		3 chunks	+4 lines, -5 lines	0 comments	Download
M	webkit/quota/quota_manager.cc	View	1	9 chunks	+12 lines, -18 lines	0 comments	Download
M	webkit/quota/quota_manager_unittest.cc	View	1	3 chunks	+4 lines, -4 lines	0 comments	Download
M	webkit/quota/quota_types.h	View		1 chunk	+1 line, -6 lines	0 comments	Download

Messages

Total messages: 9 (0 generated)

Expand Messages | Collapse Messages

kinuko

http://codereview.chromium.org/10958032/diff/1/webkit/quota/quota_manager.cc File webkit/quota/quota_manager.cc (right): http://codereview.chromium.org/10958032/diff/1/webkit/quota/quota_manager.cc#newcode361 webkit/quota/quota_manager.cc:361: QuotaCallback NewWaitableQuotaCallback() { Could we preserve this method name ...

8 years, 3 months ago (2012-09-21 08:18:31 UTC) #3

calvinlo

Running try jobs now http://codereview.chromium.org/10958032/diff/1/webkit/quota/quota_manager.cc File webkit/quota/quota_manager.cc (right): http://codereview.chromium.org/10958032/diff/1/webkit/quota/quota_manager.cc#newcode361 webkit/quota/quota_manager.cc:361: QuotaCallback NewWaitableQuotaCallback() { On 2012/09/21 ...

8 years, 3 months ago (2012-09-21 10:24:00 UTC) #4

calvinlo

Hi estade, can you please review chrome/browser/ui/webui/*. Just a few small changes to complete the ...

8 years, 3 months ago (2012-09-23 08:18:31 UTC) #6

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/calvinlo@chromium.org/10958032/5001

8 years, 2 months ago (2012-09-25 03:18:28 UTC) #8

Change committed as 158547

Expand Messages | Collapse Messages