Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(496)

Issue 10958029: Ensure WebKit is initialized in the case Loaded IPC arrives before UpdateUserScripts (Closed)

Created:
8 years, 3 months ago by tapted
Modified:
8 years, 3 months ago
CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org, darin-cc_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Ensure WebKit is initialized in the case Loaded IPC arrives before UpdateUserScripts minimal fix for crbug/150695 BUG=150695 TEST=Race condition reproduced and verified code path with trace output Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=158163

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/renderer/extensions/dispatcher.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
tapted
This one-line fix seems happy -- I've run a build with trace output to verify ...
8 years, 3 months ago (2012-09-21 02:19:50 UTC) #1
not at google - send to devlin
lgtm This seems like a good patch to merge into to prevent the crashers. As ...
8 years, 3 months ago (2012-09-21 02:23:00 UTC) #2
benwells
lgtm
8 years, 3 months ago (2012-09-21 02:27:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tapted@chromium.org/10958029/1
8 years, 3 months ago (2012-09-21 04:58:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tapted@chromium.org/10958029/1
8 years, 3 months ago (2012-09-22 00:23:37 UTC) #5
commit-bot: I haz the power
8 years, 3 months ago (2012-09-22 03:10:32 UTC) #6
Change committed as 158163

Powered by Google App Engine
This is Rietveld 408576698