Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1289)

Issue 10958026: Port ppapi_ppb_core nacl_integration test to browser_tests. (Closed)

Created:
8 years, 3 months ago by Nick Bray (chromium)
Modified:
8 years, 2 months ago
CC:
chromium-reviews, native-client-reviews_googlegroups.com
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rebase #

Patch Set 3 : Fix dependancies. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -361 lines) Patch
M chrome/test/data/nacl/DEPS View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/test/data/nacl/nacl_browser_test.gypi View 1 2 1 chunk +14 lines, -8 lines 0 comments Download
M chrome/test/data/nacl/nacl_test_data.gyp View 1 2 1 chunk +43 lines, -0 lines 0 comments Download
A + chrome/test/data/nacl/ppapi/ppb_core/ppapi_ppb_core.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/test/data/nacl/ppapi/ppb_core/ppapi_ppb_core.html View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/test/nacl/nacl_browsertest.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M ppapi/native_client/ppapi_scons_files.py View 1 chunk +0 lines, -1 line 0 comments Download
D ppapi/native_client/tests/ppapi_browser/ppb_core/nacl.scons View 1 chunk +0 lines, -41 lines 0 comments Download
D ppapi/native_client/tests/ppapi_browser/ppb_core/ppapi_ppb_core.cc View 1 chunk +0 lines, -248 lines 0 comments Download
D ppapi/native_client/tests/ppapi_browser/ppb_core/ppapi_ppb_core.html View 1 chunk +0 lines, -65 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Nick Bray (chromium)
mseaborn: reviewer because he OWNS ppapi/native_client I've asked to get me and brad in OWNERs, ...
8 years, 3 months ago (2012-09-21 00:58:29 UTC) #1
bradn
https://codereview.chromium.org/10958026/diff/1/chrome/test/data/nacl/nacl_test_data.gyp File chrome/test/data/nacl/nacl_test_data.gyp (right): https://codereview.chromium.org/10958026/diff/1/chrome/test/data/nacl/nacl_test_data.gyp#newcode59 chrome/test/data/nacl/nacl_test_data.gyp:59: 'nso_target': 'libppapi_test_lib.so', You don't really need the .so version ...
8 years, 3 months ago (2012-09-21 05:59:42 UTC) #2
bradn
On further face to face discussion we've concluded building the .so and .a for glibc ...
8 years, 3 months ago (2012-09-21 21:57:13 UTC) #3
bradn
On further face to face discussion we've concluded building the .so and .a for glibc ...
8 years, 3 months ago (2012-09-21 21:57:14 UTC) #4
bradn
LGTM
8 years, 3 months ago (2012-09-21 21:57:38 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ncbray@chromium.org/10958026/11001
8 years, 2 months ago (2012-09-25 23:33:39 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ncbray@chromium.org/10958026/11001
8 years, 2 months ago (2012-09-26 00:12:22 UTC) #7
commit-bot: I haz the power
8 years, 2 months ago (2012-09-26 01:57:45 UTC) #8
Change committed as 158714

Powered by Google App Engine
This is Rietveld 408576698