Issue 10958007: sync: Refactor CreateRoot() test helper function

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10958007: sync: Refactor CreateRoot() test helper function (Closed)

Created:
8 years, 3 months ago by rlarocque

Modified:
8 years, 3 months ago

Reviewers:
tim (not reviewing)

CC:
chromium-reviews, Raghu Simha, haitaol1, akalin, tim (not reviewing)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

sync: Refactor CreateRoot() test helper function Move the function's definition so we can eventually make use of it in FakeSyncManager to test the DEVICE_INFO type. This change also removes the unnecessary TestIdFactory parameter. BUG=122825 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=158331

Patch Set 1 #

Patch Set 2 : Found more stuff to clean up #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+49 lines, -90 lines)			Patch
M	chrome/browser/sync/abstract_profile_sync_service_test.h	View	1	1 chunk	+0 lines, -10 lines	0 comments	Download
M	chrome/browser/sync/abstract_profile_sync_service_test.cc	View	1	2 chunks	+3 lines, -57 lines	0 comments	Download
M	chrome/browser/sync/profile_sync_service_bookmark_unittest.cc	View		4 chunks	+4 lines, -12 lines	0 comments	Download
M	chrome/browser/sync/profile_sync_service_session_unittest.cc	View	1	3 chunks	+3 lines, -5 lines	0 comments	Download
M	chrome/browser/sync/profile_sync_service_typed_url_unittest.cc	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/sync/test_profile_sync_service.cc	View		3 chunks	+4 lines, -4 lines	0 comments	Download
M	sync/internal_api/public/test/test_user_share.h	View		2 chunks	+5 lines, -1 line	0 comments	Download
M	sync/internal_api/test/test_user_share.cc	View		2 chunks	+30 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

rlarocque

This is a chunk broken off of the device info review (http://codereview.chromium.org/10911073/). I'm not 100% ...

8 years, 3 months ago (2012-09-20 01:12:33 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rlarocque@chromium.org/10958007/2001

8 years, 3 months ago (2012-09-24 16:30:59 UTC) #3

Change committed as 158331

Expand Messages | Collapse Messages