net: separate SPDY cookies with "; " as the new RFC requires.

net: separate SPDY cookie with "; " as the new RFC requires.

Previously, SPDY cookies would look like:

  "FOO=BAR;BAR=BOO;WIBBLE=WOBBLE;"

With this patch they will look like:

  "FOO=BAR; BAR=BOO; WIBBLE=WOBBLE"

This will hurt compression a little as cookies are only matched completely so:

  Cookie: FOO=BAR
          |-----|

won't match against the next Cookie header with an additional cookie:

  Cookie: FOO=BAR; BAR=BOO
          |------||------|

However, once the set of cookies is stable, it does fine.

BUG=151433
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=158088

[willchan no longer on Chromium, 2012-09-21 15:57:52]

lgtm

https://codereview.chromium.org/10957038/diff/2001/net/spdy/spdy_framer.cc
File net/spdy/spdy_framer.cc (right):

https://codereview.chromium.org/10957038/diff/2001/net/spdy/spdy_framer.cc#ne...
net/spdy/spdy_framer.cc:787: } else if (i < cookie_values.size()-1) {
stupid style nit: spaces around the '-'

[agl, 2012-09-21 18:11:59]

https://codereview.chromium.org/10957038/diff/2001/net/spdy/spdy_framer.cc
File net/spdy/spdy_framer.cc (right):

https://codereview.chromium.org/10957038/diff/2001/net/spdy/spdy_framer.cc#ne...
net/spdy/spdy_framer.cc:787: } else if (i < cookie_values.size()-1) {
On 2012/09/21 15:57:52, willchan wrote:
> stupid style nit: spaces around the '-'

Done.

[commit-bot: I haz the power, 2012-09-21 18:12:20]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/agl@chromium.org/10957038/7001

[commit-bot: I haz the power, 2012-09-21 21:49:15]

Change committed as 158088