Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(376)

Issue 10957032: Added OtherDateLabel localized string. (Closed)

Created:
8 years, 3 months ago by keishi
Modified:
8 years, 3 months ago
Reviewers:
tony
CC:
chromium-reviews, darin-cc_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Added OtherDateLabel localized string. It will be used in WebKit for the date suggestion picker popup. BUG=151480 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=158528

Patch Set 1 #

Total comments: 1

Patch Set 2 : Added meaning attribute #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M webkit/glue/webkit_strings.grd View 1 1 chunk +3 lines, -0 lines 0 comments Download
M webkit/glue/webkitplatformsupport_impl.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
keishi
8 years, 3 months ago (2012-09-21 05:52:24 UTC) #1
tony
https://chromiumcodereview.appspot.com/10957032/diff/1/webkit/glue/webkit_strings.grd File webkit/glue/webkit_strings.grd (right): https://chromiumcodereview.appspot.com/10957032/diff/1/webkit/glue/webkit_strings.grd#newcode264 webkit/glue/webkit_strings.grd:264: <message name="IDS_FORM_OTHER_DATE_LABEL" desc="Label for button that opens a full ...
8 years, 3 months ago (2012-09-21 19:05:02 UTC) #2
keishi
On 2012/09/21 19:05:02, tony wrote: > https://chromiumcodereview.appspot.com/10957032/diff/1/webkit/glue/webkit_strings.grd > File webkit/glue/webkit_strings.grd (right): > > https://chromiumcodereview.appspot.com/10957032/diff/1/webkit/glue/webkit_strings.grd#newcode264 > ...
8 years, 3 months ago (2012-09-24 05:06:23 UTC) #3
tony
LGTM
8 years, 3 months ago (2012-09-24 18:17:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/keishi@chromium.org/10957032/4001
8 years, 3 months ago (2012-09-25 00:39:12 UTC) #5
commit-bot: I haz the power
Retried try job too often for step(s) content_browsertests
8 years, 3 months ago (2012-09-25 02:52:54 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/keishi@chromium.org/10957032/4001
8 years, 3 months ago (2012-09-25 03:07:03 UTC) #7
commit-bot: I haz the power
8 years, 3 months ago (2012-09-25 05:01:30 UTC) #8
Change committed as 158528

Powered by Google App Engine
This is Rietveld 408576698