Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5849)

Unified Diff: chrome/browser/ui/webui/about_ui.cc

Issue 10957027: Add Application version and OS info in android about version page. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/about_ui.cc
diff --git a/chrome/browser/ui/webui/about_ui.cc b/chrome/browser/ui/webui/about_ui.cc
index 69262e509417a708c48b5268ed9da4969f391eeb..1f2b45b58ec6b83cfcbf2feb6b2491635b9479fb 100644
--- a/chrome/browser/ui/webui/about_ui.cc
+++ b/chrome/browser/ui/webui/about_ui.cc
@@ -78,6 +78,11 @@
#include "chrome/browser/ui/webui/theme_source.h"
#endif
+#if defined(OS_ANDROID)
+#include "base/android/build_info.h"
+#include "chrome/browser/ui/android/android_about_app_info.h"
+#endif
+
#if defined(OS_LINUX) || defined(OS_OPENBSD)
#include "content/public/browser/zygote_host_linux.h"
#include "content/public/common/sandbox_linux.h"
@@ -1130,7 +1135,19 @@ void HandleAboutVersionStrings(AboutUIHTMLSource* source,
new ChromeOSAboutVersionHandler(source, request_id);
#else
DictionaryValue localized_strings;
+#if defined(OS_ANDROID)
+ localized_strings.SetString("application",
+ l10n_util::GetStringUTF16(IDS_ABOUT_VERSION_APPLICATION));
+ base::android::BuildInfo* android_build_info =
+ base::android::BuildInfo::GetInstance();
+ localized_strings.SetString("app_label",
+ android_build_info->package_label());
+ localized_strings.SetString("app_version",
+ android_build_info->package_version_name());
+ localized_strings.SetString("os_version", AndroidAboutAppInfo::GetOsInfo());
+#else
localized_strings.SetString("os_version", "");
+#endif
source->FinishDataRequest(
AboutVersionStrings(&localized_strings, source->profile()),
request_id);

Powered by Google App Engine
This is Rietveld 408576698