Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(453)

Side by Side Diff: chrome/browser/ui/android/android_about_app_info.cc

Issue 10957027: Add Application version and OS info in android about version page. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Adding the class back. Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/browser/ui/android/android_about_app_info.h ('k') | chrome/chrome_browser_ui.gypi » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
(Empty)
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "chrome/browser/ui/android/android_about_app_info.h"
6
7 #include <string>
8
9 #include "base/stringprintf.h"
10 #include "base/sys_info.h"
11
12 std::string AndroidAboutAppInfo::GetOsInfo() {
13 std::string android_info_str;
14
15 // Append information about the OS version.
16 int32 os_major_version = 0;
17 int32 os_minor_version = 0;
18 int32 os_bugfix_version = 0;
19 base::SysInfo::OperatingSystemVersionNumbers(&os_major_version,
20 &os_minor_version,
21 &os_bugfix_version);
22 base::StringAppendF(&android_info_str, "%d.%d.%d", os_major_version,
23 os_minor_version, os_bugfix_version);
24
25 // Append information about the device.
26 bool semicolon_inserted = false;
27 std::string android_build_codename = base::SysInfo::GetAndroidBuildCodename();
28 std::string android_device_name = base::SysInfo::GetDeviceName();
29 if ("REL" == android_build_codename && android_device_name.size() > 0) {
30 android_info_str += "; " + android_device_name;
31 semicolon_inserted = true;
32 }
33
34 // Append the build ID.
35 std::string android_build_id = base::SysInfo::GetAndroidBuildID();
36 if (android_build_id.size() > 0) {
37 if (!semicolon_inserted) {
38 android_info_str += ";";
39 }
40 android_info_str += " Build/" + android_build_id;
41 }
42
43 return android_info_str;
44 }
OLDNEW
« no previous file with comments | « chrome/browser/ui/android/android_about_app_info.h ('k') | chrome/chrome_browser_ui.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698