Issue 10957021: PPAPI/NaCl: Set the PluginProxyDelegate for the IPC proxy

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10957021: PPAPI/NaCl: Set the PluginProxyDelegate for the IPC proxy (Closed)

Created:
8 years, 3 months ago by dmichael (off chromium)

Modified:
8 years, 3 months ago

Reviewers:
bbudge

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

PPAPI/NaCl: Set the PluginProxyDelegate for the IPC proxy Makes URLRequestInfo work again for the IPC proxy. BUG=116317 TEST=URLLoader SDK example works again Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=157861

Patch Set 1 #

Total comments: 1

Patch Set 2 : review comments #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	ppapi/proxy/plugin_main_nacl.cc	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

bbudge

LGTM http://codereview.chromium.org/10957021/diff/1/ppapi/proxy/plugin_main_nacl.cc File ppapi/proxy/plugin_main_nacl.cc (right): http://codereview.chromium.org/10957021/diff/1/ppapi/proxy/plugin_main_nacl.cc#newcode263 ppapi/proxy/plugin_main_nacl.cc:263: PluginGlobals::Get()->set_plugin_proxy_delegate(&ppapi_dispatcher); Can't you use plugin_globals, above?

8 years, 3 months ago (2012-09-20 18:15:24 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmichael@chromium.org/10957021/3001

8 years, 3 months ago (2012-09-20 18:21:07 UTC) #3

Change committed as 157861

Expand Messages | Collapse Messages