Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issue 10956065: Handle crashing Pepper plug-ins the same as crashing NPAPI plug-ins. (Closed)

Created:
8 years, 3 months ago by Chris Evans
Modified:
8 years, 3 months ago
Reviewers:
Bernhard Bauer, jam
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Handle crashing Pepper plug-ins the same as crashing NPAPI plug-ins. BUG=151895 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=158364

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -3 lines) Patch
M chrome/browser/renderer_host/plugin_info_message_filter.cc View 1 2 chunks +11 lines, -3 lines 0 comments Download
M content/browser/ppapi_plugin_process_host.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/ppapi_plugin_process_host.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Chris Evans
8 years, 3 months ago (2012-09-24 08:39:34 UTC) #1
Bernhard Bauer
https://codereview.chromium.org/10956065/diff/1/chrome/browser/renderer_host/plugin_info_message_filter.cc File chrome/browser/renderer_host/plugin_info_message_filter.cc (right): https://codereview.chromium.org/10956065/diff/1/chrome/browser/renderer_host/plugin_info_message_filter.cc#newcode202 chrome/browser/renderer_host/plugin_info_message_filter.cc:202: plugin_setting != CONTENT_SETTING_BLOCK && I think we should also ...
8 years, 3 months ago (2012-09-24 08:50:53 UTC) #2
Bernhard Bauer
LGTM!
8 years, 3 months ago (2012-09-24 08:59:45 UTC) #3
jam
lgtm
8 years, 3 months ago (2012-09-24 15:26:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cevans@chromium.org/10956065/5001
8 years, 3 months ago (2012-09-24 17:57:17 UTC) #5
commit-bot: I haz the power
8 years, 3 months ago (2012-09-24 20:05:04 UTC) #6
Change committed as 158364

Powered by Google App Engine
This is Rietveld 408576698