Issue 10956065: Handle crashing Pepper plug-ins the same as crashing NPAPI plug-ins.

Issue 10956065: Handle crashing Pepper plug-ins the same as crashing NPAPI plug-ins. (Closed)

Created:
8 years, 3 months ago by Chris Evans

Modified:
8 years, 3 months ago

Reviewers:
Bernhard Bauer, jam

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Handle crashing Pepper plug-ins the same as crashing NPAPI plug-ins. BUG=151895 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=158364

Patch Set 2 : #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -3 lines)			Patch
M	chrome/browser/renderer_host/plugin_info_message_filter.cc	View	1	2 chunks	+11 lines, -3 lines	0 comments	Download
M	content/browser/ppapi_plugin_process_host.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	content/browser/ppapi_plugin_process_host.cc	View		1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Bernhard Bauer

https://codereview.chromium.org/10956065/diff/1/chrome/browser/renderer_host/plugin_info_message_filter.cc File chrome/browser/renderer_host/plugin_info_message_filter.cc (right): https://codereview.chromium.org/10956065/diff/1/chrome/browser/renderer_host/plugin_info_message_filter.cc#newcode202 chrome/browser/renderer_host/plugin_info_message_filter.cc:202: plugin_setting != CONTENT_SETTING_BLOCK && I think we should also ...

8 years, 3 months ago (2012-09-24 08:50:53 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cevans@chromium.org/10956065/5001

8 years, 3 months ago (2012-09-24 17:57:17 UTC) #5

Change committed as 158364

Expand Messages | Collapse Messages