Add a ListModel::Move.

Add a ListModel::Move.

It will be used for app list drag-n-drop reodering.

BUG=117090
TEST=ListModelTest.* should pass.

R=sky@chromium.org


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=158469

[tfarina, 2012-09-24 21:02:00]

http://codereview.chromium.org/10956052/diff/2001/ui/base/models/list_model_u...
File ui/base/models/list_model_unittest.cc (right):

http://codereview.chromium.org/10956052/diff/2001/ui/base/models/list_model_u...
ui/base/models/list_model_unittest.cc:88: // Total 3 items in mode.
nit: s/mode/model.

http://codereview.chromium.org/10956052/diff/2001/ui/base/models/list_model_u...
ui/base/models/list_model_unittest.cc:134: // Remove all items and scoped_ptr
above would release memory.
doesn't allocating them in the stack instead of heap doesn't do the trick? not
big deal though.

[sky, 2012-09-24 21:27:58]

LGTM

[xiyuan, 2012-09-24 21:34:11]

http://codereview.chromium.org/10956052/diff/2001/ui/base/models/list_model_u...
File ui/base/models/list_model_unittest.cc (right):

http://codereview.chromium.org/10956052/diff/2001/ui/base/models/list_model_u...
ui/base/models/list_model_unittest.cc:88: // Total 3 items in mode.
On 2012/09/24 21:02:00, tfarina wrote:
> nit: s/mode/model.

Done.

http://codereview.chromium.org/10956052/diff/2001/ui/base/models/list_model_u...
ui/base/models/list_model_unittest.cc:134: // Remove all items and scoped_ptr
above would release memory.
On 2012/09/24 21:02:00, tfarina wrote:
> doesn't allocating them in the stack instead of heap doesn't do the trick? not
> big deal though.

That should work too. But think using a scoped_ptr makes it more clear of who's
managing the memory.

[commit-bot: I haz the power, 2012-09-24 22:54:10]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/xiyuan@chromium.org/10956052/8001

[commit-bot: I haz the power, 2012-09-25 00:49:13]

Change committed as 158469