Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issue 10956034: Switching from ForXyz naming to FromXyz naming, for consistency. (Closed)

Created:
8 years, 3 months ago by Jói
Modified:
8 years, 3 months ago
Reviewers:
Cait (Slow)
CC:
chromium-reviews, jam, akalin, Raghu Simha, browser-components-watch_chromium.org, darin-cc_chromium.org, dyu1, dhollowa+watch_chromium.org, stuartmorgan+watch_chromium.org, haitaol1, Ilya Sherman, tim (not reviewing)
Visibility:
Public.

Description

Switching from ForXyz naming to FromXyz naming, for consistency. TBR=mechanicalowners@chromium.org BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=158186

Patch Set 1 #

Patch Set 2 : Merge to head #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -50 lines) Patch
M chrome/browser/api/infobars/infobar_service.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/api/prefs/pref_service_base.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/api/sync/profile_sync_service_base.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/api/webdata/autofill_web_data_service.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autofill/autocomplete_history_manager.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/autofill/autofill_browsertest.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/autofill/autofill_common_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autofill/autofill_download.cc View 3 chunks +6 lines, -3 lines 0 comments Download
M chrome/browser/autofill/autofill_manager_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/autofill/autofill_metrics_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autofill/personal_data_manager.cc View 18 chunks +22 lines, -22 lines 0 comments Download
M chrome/browser/infobars/infobar_tab_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/plugins/plugin_infobar_delegates.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/prefs/pref_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/profile_sync_service_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options/preferences_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/webdata/web_data_service_factory.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Jói
8 years, 3 months ago (2012-09-21 11:37:50 UTC) #1
Cait (Slow)
lgtm
8 years, 3 months ago (2012-09-21 14:12:28 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joi@chromium.org/10956034/1
8 years, 3 months ago (2012-09-21 16:22:34 UTC) #3
commit-bot: I haz the power
Failed to apply patch for chrome/browser/plugin_infobar_delegates.cc: While running patch -p1 --forward --force; patching file chrome/browser/plugin_infobar_delegates.cc ...
8 years, 3 months ago (2012-09-21 16:22:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joi@chromium.org/10956034/19
8 years, 3 months ago (2012-09-22 12:11:10 UTC) #5
commit-bot: I haz the power
8 years, 3 months ago (2012-09-22 17:02:27 UTC) #6
Change committed as 158186

Powered by Google App Engine
This is Rietveld 408576698