Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(923)

Unified Diff: build/common.gypi

Issue 10956019: Upstream the CL to remove the target_arch x86 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index e3dee3515dd32c263ce2075f4dd5bbf74385949c..a6ba88088eb46ac456e34f5f21dd31980aad32b4 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -989,28 +989,30 @@
# Location of Android NDK.
'variables': {
'variables': {
- 'android_ndk_root%': '<!(/bin/echo -n $ANDROID_NDK_ROOT)',
- # Android uses x86 instead of ia32 for their target_arch
- # designation.
- # TODO(wistoch): Adjust the target_arch naming scheme to avoid
- # confusion.
- # http://crbug.com/125329
+ 'variables': {
+ 'android_ndk_root%': '<!(/bin/echo -n $ANDROID_NDK_ROOT)',
+ },
+ 'android_ndk_root%': '<(android_ndk_root)',
'conditions': [
['target_arch == "ia32"', {
- 'target_arch': 'x86',
'android_app_abi%': 'x86',
+ 'android_ndk_sysroot%': '<(android_ndk_root)/platforms/android-9/arch-x86',
}],
- ['target_arch=="arm" and armv7==0', {
- 'android_app_abi%': 'armeabi',
- }],
- ['target_arch=="arm" and armv7==1', {
- 'android_app_abi%': 'armeabi-v7a',
+ ['target_arch=="arm"', {
+ 'android_ndk_sysroot%': '<(android_ndk_root)/platforms/android-9/arch-arm',
+ 'conditions': [
+ ['armv7==0', {
+ 'android_app_abi%': 'armeabi',
+ }, {
+ 'android_app_abi%': 'armeabi-v7a',
+ }],
+ ],
}],
],
},
'android_ndk_root%': '<(android_ndk_root)',
- 'android_ndk_sysroot%': '<(android_ndk_root)/platforms/android-9/arch-<(target_arch)',
'android_app_abi%': '<(android_app_abi)',
+ 'android_ndk_sysroot%': '<(android_ndk_sysroot)',
},
'android_ndk_root%': '<(android_ndk_root)',
'android_ndk_sysroot': '<(android_ndk_sysroot)',
@@ -2581,7 +2583,6 @@
# Android-specific options; note that most are set above with Linux.
['OS=="android"', {
'variables': {
- 'target_arch%': 'arm', # target_arch in android terms.
# This is the id for the archived chrome symbols. Each build that
# archives symbols is assigned an id which is then added to GYP_DEFINES.
# This is written to the device log on crashes just prior to dropping a
@@ -2589,10 +2590,6 @@
# from the id.
'chrome_symbols_id%': '',
'conditions': [
- # Android uses x86 instead of ia32 for their target_arch designation.
- ['target_arch=="ia32"', {
- 'target_arch%': 'x86',
- }],
# Use shared stlport library when system one used.
# Figure this out early since it needs symbols from libgcc.a, so it
# has to be before that in the set of libraries.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698