Issue 10956004: Notify host of initial client dimensions.

Issue 10956004: Notify host of initial client dimensions. (Closed)

Created:
8 years, 3 months ago by Jamie

Modified:
8 years, 3 months ago

Reviewers:
Wez

CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, simonmorris+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, rmsousa+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Notify host of initial client dimensions. BUG=145049 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=157842

Patch Set 1 #

Total comments: 2

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	remoting/webapp/client_session.js	View		1 chunk	+1 line, -0 lines	2 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Wez

lgtm https://codereview.chromium.org/10956004/diff/1/remoting/webapp/client_session.js File remoting/webapp/client_session.js (right): https://codereview.chromium.org/10956004/diff/1/remoting/webapp/client_session.js#newcode520 remoting/webapp/client_session.js:520: this.plugin.notifyClientDimensions(window.innerWidth, window.innerHeight) nit: Just call this.onResize_() here?

8 years, 3 months ago (2012-09-20 18:15:35 UTC) #2

Jamie

fyi https://codereview.chromium.org/10956004/diff/1/remoting/webapp/client_session.js File remoting/webapp/client_session.js (right): https://codereview.chromium.org/10956004/diff/1/remoting/webapp/client_session.js#newcode520 remoting/webapp/client_session.js:520: this.plugin.notifyClientDimensions(window.innerWidth, window.innerHeight) On 2012/09/20 18:15:36, Wez wrote: > ...

8 years, 3 months ago (2012-09-20 18:26:56 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamiewalch@chromium.org/10956004/1

8 years, 3 months ago (2012-09-20 18:27:48 UTC) #4

Change committed as 157842

Expand Messages | Collapse Messages