Issue 10952029: Remove native side of content_view_client

Issue 10952029: Remove native side of content_view_client (Closed)

Created:
8 years, 3 months ago by Yusuf

Modified:
8 years, 3 months ago

Reviewers:
Ted C, jam, Yaron, mkosiba (inactive), Jay Civelli

CC:
chromium-reviews, cbentzel+watch_chromium.org, ctguil+watch_chromium.org, hashimoto+watch_chromium.org, aboxhall+watch_chromium.org, yoshiki+watch_chromium.org, jam, yuzo+watch_chromium.org, davidbarr+watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, erikwright+watch_chromium.org, zork+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Remove native side of content_view_client This moves related callabcks from content_view_client to web_contents_observer_android and makes the client a Java only API. BUG=137967 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=158067

Patch Set 1 #

Total comments: 1

Patch Set 2 : Added TestCallbackHelperContainerHelper changes #

Patch Set 3 : Rebased and resolved conflicts with content_view_core.h changes #

Patch Set 4 : Fixed a conflict that I had missed #

Patch Set 5 : Fixed build errors #

Total comments: 2

Patch Set 6 : Rebased and added TestAwContentsClient changes #

Patch Set 7 : Rebased #

Patch Set 8 : Nit fixes #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+267 lines, -514 lines)			Patch
M	android_webview/java/src/org/chromium/android_webview/AwContentsClient.java	View	1 2 3 4 5	3 chunks	+31 lines, -4 lines	0 comments	Download
A	android_webview/java/src/org/chromium/android_webview/ErrorCodeConversionHelper.java	View		1 chunk	+143 lines, -0 lines	0 comments	Download
M	android_webview/javatests/src/org/chromium/android_webview/test/NullContentsClient.java	View	1 2 3 4 5	1 chunk	+12 lines, -0 lines	0 comments	Download
M	android_webview/javatests/src/org/chromium/android_webview/test/TestAwContentsClient.java	View	1 2 3 4 5	1 chunk	+0 lines, -9 lines	0 comments	Download
M	base/android/jni_generator/jni_generator.py	View	1 2 3 4 5	1 chunk	+0 lines, -1 line	0 comments	Download
M	content/browser/android/browser_jni_registrar.cc	View	1 2	2 chunks	+0 lines, -2 lines	0 comments	Download
D	content/browser/android/content_view_client.h	View	1 2 3 4 5	1 chunk	+0 lines, -101 lines	0 comments	Download
D	content/browser/android/content_view_client.cc	View	1 2 3 4 5	1 chunk	+0 lines, -240 lines	0 comments	Download
M	content/browser/android/content_view_core_impl.h	View	1 2 3 4 5 6	3 chunks	+0 lines, -5 lines	0 comments	Download
M	content/browser/android/content_view_core_impl.cc	View	1 2	2 chunks	+0 lines, -8 lines	0 comments	Download
M	content/browser/android/web_contents_observer_android.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	content/browser/android/web_contents_observer_android.cc	View	1 2	2 chunks	+19 lines, -4 lines	0 comments	Download
M	content/content_browser.gypi	View	1 2	1 chunk	+0 lines, -2 lines	0 comments	Download
M	content/content_jni.gypi	View	1 2	1 chunk	+0 lines, -1 line	0 comments	Download
M	content/public/android/java/src/org/chromium/content/browser/ContentViewClient.java	View	1 2 3 4 5	1 chunk	+0 lines, -56 lines	0 comments	Download
M	content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java	View	1 2	8 chunks	+13 lines, -13 lines	0 comments	Download
M	content/public/android/java/src/org/chromium/content/browser/WebContentsObserverAndroid.java	View		3 chunks	+12 lines, -3 lines	0 comments	Download
M	content/public/android/java/src/org/chromium/content/browser/accessibility/AccessibilityInjector.java	View		4 chunks	+10 lines, -2 lines	0 comments	Download
M	content/public/android/javatests/src/org/chromium/content/browser/util/TestCallbackHelperContainer.java	View	1 2	2 chunks	+5 lines, -3 lines	0 comments	Download
M	content/public/android/javatests/src/org/chromium/content/browser/util/TestContentViewClient.java	View	1 2 3	2 chunks	+0 lines, -36 lines	0 comments	Download
A +	content/public/android/javatests/src/org/chromium/content/browser/util/TestWebContentsObserver.java	View	1 2 3 4 5	3 chunks	+19 lines, -23 lines	0 comments	Download
M	net/android/java/net_errors_java.template	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

Ted C

lgtm...with the rebase and resolving Nilesh's change https://codereview.chromium.org/10952029/diff/1/content/public/browser/android/content_view_core.h File content/public/browser/android/content_view_core.h (right): https://codereview.chromium.org/10952029/diff/1/content/public/browser/android/content_view_core.h#newcode49 content/public/browser/android/content_view_core.h:49: virtual content::WebContents* ...

8 years, 3 months ago (2012-09-20 17:28:45 UTC) #2

Yaron

https://codereview.chromium.org/10952029/diff/8022/android_webview/javatests/src/org/chromium/android_webview/test/NullContentsClient.java File android_webview/javatests/src/org/chromium/android_webview/test/NullContentsClient.java (right): https://codereview.chromium.org/10952029/diff/8022/android_webview/javatests/src/org/chromium/android_webview/test/NullContentsClient.java#newcode40 android_webview/javatests/src/org/chromium/android_webview/test/NullContentsClient.java:40: You probably need to rebase on top of http://codereview.chromium.org/10907166/ ...

8 years, 3 months ago (2012-09-20 20:56:52 UTC) #3

jam

lgtm. as Yaron says, you can TBR trivial changes to gyp like this, or also ...

8 years, 3 months ago (2012-09-21 16:03:23 UTC) #6

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yusufo@chromium.org/10952029/11005

8 years, 3 months ago (2012-09-21 17:38:00 UTC) #7

Change committed as 158067

Expand Messages | Collapse Messages