Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1068)

Issue 10952025: [Android] Make OS version reporting in the UA string legacy-compatible. (Closed)

Created:
8 years, 3 months ago by mnaganov (inactive)
Modified:
8 years, 3 months ago
Reviewers:
tony, gone, android-webview-reviews
CC:
chromium-reviews, darin-cc_chromium.org
Visibility:
Public.

Description

[Android] Make OS version reporting in the UA string legacy-compatible. Android CTS tests require that the trailing "zero" bugfix revision must not be included ("4.1" not "4.1.0"). R=dfalcantara@chromium.org,android-webview-reviews@google.com BUG=131312 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=157738

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -4 lines) Patch
M webkit/user_agent/user_agent_util.cc View 2 chunks +8 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
mnaganov (inactive)
8 years, 3 months ago (2012-09-19 14:25:34 UTC) #1
gone
On 2012/09/19 14:25:34, Mikhail Naganov (Chromium) wrote: LGTM, but you're going to need an owner ...
8 years, 3 months ago (2012-09-19 17:19:49 UTC) #2
gone
Adding tony to get your OWNER permission.
8 years, 3 months ago (2012-09-19 17:20:55 UTC) #3
tony
LGTM, but can you add a test case for this? Maybe you can add it ...
8 years, 3 months ago (2012-09-19 17:50:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mnaganov@chromium.org/10952025/1
8 years, 3 months ago (2012-09-20 08:36:55 UTC) #5
mnaganov (inactive)
On 2012/09/19 17:50:03, tony wrote: > LGTM, but can you add a test case for ...
8 years, 3 months ago (2012-09-20 08:40:46 UTC) #6
commit-bot: I haz the power
8 years, 3 months ago (2012-09-20 10:43:59 UTC) #7
Change committed as 157738

Powered by Google App Engine
This is Rietveld 408576698