Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Issue 10952023: Add yasm flags for 64-bit mac builds (Closed)

Created:
8 years, 3 months ago by Cătălin Badea
Modified:
8 years, 3 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews, Mihai Maerean
Visibility:
Public.

Description

Add yasm flags for 64-bit mac builds. BUG=150760, 150980 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=157771

Patch Set 1 : Better Readme file. #

Total comments: 1

Patch Set 2 : Removed Readme modifications. #

Total comments: 1

Patch Set 3 : Removed comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M third_party/yasm/yasm_compile.gypi View 1 2 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Cătălin Badea
This patch addresses 64-bit mac build issues related to third_party/libvpx and media/yuv_converter 64-bit. Please review.
8 years, 3 months ago (2012-09-19 13:41:20 UTC) #1
Mark Mentovai
https://codereview.chromium.org/10952023/diff/2001/third_party/yasm/README.chromium File third_party/yasm/README.chromium (right): https://codereview.chromium.org/10952023/diff/2001/third_party/yasm/README.chromium#newcode18 third_party/yasm/README.chromium:18: - yasm.gyp was modified to include flags for 64-bit ...
8 years, 3 months ago (2012-09-19 13:42:41 UTC) #2
Cătălin Badea
I removed the readme modifications from the patch set.
8 years, 3 months ago (2012-09-19 13:48:02 UTC) #3
Mark Mentovai
https://codereview.chromium.org/10952023/diff/6001/third_party/yasm/yasm_compile.gypi File third_party/yasm/yasm_compile.gypi (right): https://codereview.chromium.org/10952023/diff/6001/third_party/yasm/yasm_compile.gypi#newcode61 third_party/yasm/yasm_compile.gypi:61: '-m', 'amd64', # yasm uses 'amd64' as flag for ...
8 years, 3 months ago (2012-09-19 13:50:53 UTC) #4
Cătălin Badea
I removed the comment.
8 years, 3 months ago (2012-09-19 13:56:24 UTC) #5
Cătălin Badea
Should I also ping an owner from src/media/ as this patch affects the build process ...
8 years, 3 months ago (2012-09-20 08:24:12 UTC) #6
Mark Mentovai
LGTM. Additional reviews are at your own discretion.
8 years, 3 months ago (2012-09-20 12:27:50 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/badea@adobe.com/10952023/10001
8 years, 3 months ago (2012-09-20 12:35:55 UTC) #8
commit-bot: I haz the power
8 years, 3 months ago (2012-09-20 15:27:17 UTC) #9
Change committed as 157771

Powered by Google App Engine
This is Rietveld 408576698