Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 10951020: Show a helpful error message if a host domain policy blocked an attempt to use (Closed)

Created:
8 years, 3 months ago by simonmorris
Modified:
8 years, 3 months ago
Reviewers:
Jamie
CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, simonmorris+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, rmsousa+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org
Visibility:
Public.

Description

Show a helpful error message if a host domain policy blocked an attempt to use IT2Me to share a computer. BUG=140386 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=157620

Patch Set 1 #

Total comments: 4

Patch Set 2 : Review. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -7 lines) Patch
M remoting/host/plugin/host_script_object.h View 2 chunks +4 lines, -3 lines 0 comments Download
M remoting/host/plugin/host_script_object.cc View 5 chunks +10 lines, -2 lines 0 comments Download
M remoting/webapp/_locales/en/messages.json View 1 1 chunk +4 lines, -0 lines 0 comments Download
M remoting/webapp/host_screen.js View 1 chunk +3 lines, -0 lines 0 comments Download
M remoting/webapp/host_session.js View 1 chunk +2 lines, -1 line 0 comments Download
M remoting/webapp/remoting.js View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
simonmorris
ptal
8 years, 3 months ago (2012-09-18 23:52:46 UTC) #1
Jamie
lgtm with a couple of suggestions. Please don't commit before the branch point is announced ...
8 years, 3 months ago (2012-09-19 17:37:59 UTC) #2
simonmorris
http://codereview.chromium.org/10951020/diff/1/remoting/webapp/_locales.official/en/messages.json File remoting/webapp/_locales.official/en/messages.json (right): http://codereview.chromium.org/10951020/diff/1/remoting/webapp/_locales.official/en/messages.json#newcode117 remoting/webapp/_locales.official/en/messages.json:117: "message": "This computer does not let you use it ...
8 years, 3 months ago (2012-09-19 18:01:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/simonmorris@chromium.org/10951020/9
8 years, 3 months ago (2012-09-19 19:52:06 UTC) #4
commit-bot: I haz the power
8 years, 3 months ago (2012-09-19 22:08:55 UTC) #5
Change committed as 157620

Powered by Google App Engine
This is Rietveld 408576698