Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issue 10950008: cc: Remove CCTextureUpdateController::updateTextures(). (Closed)

Created:
8 years, 3 months ago by reveman
Modified:
8 years, 3 months ago
Reviewers:
nduca
CC:
chromium-reviews, cc-bugs_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

cc: Remove CCTextureUpdateController::updateTextures(). Remove updateTextures() and instead use a CCTextureUpdateController instance when updating textures from CCSingleThreadProxy. BUG= TEST=cc_unittests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=157722

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+144 lines, -118 lines) Patch
M cc/CCSingleThreadProxy.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M cc/CCSingleThreadProxy.cpp View 1 2 3 chunks +12 lines, -5 lines 0 comments Download
M cc/CCTextureUpdateController.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M cc/CCTextureUpdateController.cpp View 1 2 2 chunks +33 lines, -38 lines 0 comments Download
M cc/CCTextureUpdateControllerTest.cpp View 1 2 8 chunks +19 lines, -8 lines 0 comments Download
M cc/TiledLayerChromiumTest.cpp View 1 2 47 chunks +79 lines, -65 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
reveman
More update controller cleanup as discussed.
8 years, 3 months ago (2012-09-18 15:52:08 UTC) #1
nduca
LGTM
8 years, 3 months ago (2012-09-19 16:48:01 UTC) #2
nduca
Are you landing this?
8 years, 3 months ago (2012-09-20 04:36:57 UTC) #3
reveman
On 2012/09/20 04:36:57, nduca wrote: > Are you landing this? sorry, forgot about it. here ...
8 years, 3 months ago (2012-09-20 05:09:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/reveman@chromium.org/10950008/6001
8 years, 3 months ago (2012-09-20 05:10:15 UTC) #5
commit-bot: I haz the power
Failed to apply patch for webkit/compositor_bindings/TiledLayerChromiumTest.cpp: While running patch -p1 --forward --force; patching file webkit/compositor_bindings/TiledLayerChromiumTest.cpp ...
8 years, 3 months ago (2012-09-20 05:10:20 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/reveman@chromium.org/10950008/16001
8 years, 3 months ago (2012-09-20 05:26:36 UTC) #7
commit-bot: I haz the power
8 years, 3 months ago (2012-09-20 07:27:35 UTC) #8
Change committed as 157722

Powered by Google App Engine
This is Rietveld 408576698