Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(914)

Unified Diff: lib/coreimpl/date.dart

Issue 10950006: Convert most interfaces in dart:core to abstract classes. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Address review comments. Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/coreimpl/corelib_impl_sources.gypi ('k') | lib/coreimpl/duration_implementation.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/coreimpl/date.dart
diff --git a/lib/coreimpl/date.dart b/lib/coreimpl/date.dart
index 4396a8915f9fca3f36b5bf58bc6caac53a49e408..eff1034de2426e5869021cb55f68b1b22240e9cf 100644
--- a/lib/coreimpl/date.dart
+++ b/lib/coreimpl/date.dart
@@ -62,7 +62,7 @@ class DateImplementation implements Date {
static const int _MAX_MILLISECONDS_SINCE_EPOCH = 8640000000000000;
DateImplementation.fromMillisecondsSinceEpoch(this.millisecondsSinceEpoch,
- [this.isUtc = false]) {
+ this.isUtc) {
if (millisecondsSinceEpoch.abs() > _MAX_MILLISECONDS_SINCE_EPOCH) {
throw new IllegalArgumentException(millisecondsSinceEpoch);
}
@@ -159,14 +159,15 @@ class DateImplementation implements Date {
return new Duration(milliseconds: ms - otherMs);
}
+ // TODO(lrn): Make parameters not optional for the implementation class.
external DateImplementation(int year,
- [int month,
- int day,
- int hour,
- int minute,
- int second,
- int millisecond,
- bool isUtc]);
+ [int month = 1,
+ int day = 1,
+ int hour = 0,
+ int minute = 0,
+ int second = 0,
+ int millisecond = 0,
+ bool isUtc = false]);
external DateImplementation.now();
external static int _brokenDownDateToMillisecondsSinceEpoch(
int years, int month, int day, int hour, int minute, int second,
« no previous file with comments | « lib/coreimpl/corelib_impl_sources.gypi ('k') | lib/coreimpl/duration_implementation.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698