lib/coreimpl/collections.dart - Issue 10950006: Convert most interfaces in dart:core to abstract classes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: lib/coreimpl/collections.dart

Issue 10950006: Convert most interfaces in dart:core to abstract classes. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Address review comments. Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: lib/coreimpl/collections.dart

diff --git a/lib/coreimpl/collections.dart b/lib/coreimpl/collections.dart

index 7786d3d364f1457d4361282fb304d47ad4a1b4d3..07f0abad47e1bd4005746a6a55f85522b184e4a5 100644

--- a/lib/coreimpl/collections.dart

+++ b/lib/coreimpl/collections.dart

@@ -138,7 +138,7 @@ class Collections {

Maps._emitMap(o, result, visiting);

}

} else { // o is neither a collection nor a map

- result.add(o == null ? 'null' : o); // TODO(jjb): remove the null check

+ result.add(o);

}

« no previous file with comments | « lib/core/strings.dart ('k') | lib/coreimpl/coreimpl.dart » ('j') | no next file with comments »