Chromium Code Reviews| Index: lib/coreimpl/date.dart |
| diff --git a/lib/coreimpl/date.dart b/lib/coreimpl/date.dart |
| index 4396a8915f9fca3f36b5bf58bc6caac53a49e408..78cd035e2587613075edbfa5419cee83bd1e48a2 100644 |
| --- a/lib/coreimpl/date.dart |
| +++ b/lib/coreimpl/date.dart |
| @@ -62,7 +62,7 @@ class DateImplementation implements Date { |
| static const int _MAX_MILLISECONDS_SINCE_EPOCH = 8640000000000000; |
| DateImplementation.fromMillisecondsSinceEpoch(this.millisecondsSinceEpoch, |
| - [this.isUtc = false]) { |
| + this.isUtc) { |
| if (millisecondsSinceEpoch.abs() > _MAX_MILLISECONDS_SINCE_EPOCH) { |
| throw new IllegalArgumentException(millisecondsSinceEpoch); |
| } |
| @@ -160,13 +160,13 @@ class DateImplementation implements Date { |
| } |
| external DateImplementation(int year, |
| - [int month, |
| - int day, |
| - int hour, |
| - int minute, |
| - int second, |
| - int millisecond, |
| - bool isUtc]); |
| + [int month = 1, |
|
ahe
2012/09/18 12:30:56
Remove optionality, or add TODO.
Lasse Reichstein Nielsen
2012/09/18 12:39:42
Adding TODO for now. This is an external construct
|
| + int day = 1, |
| + int hour = 0, |
| + int minute = 0, |
| + int second = 0, |
| + int millisecond = 0, |
| + bool isUtc = false]); |
| external DateImplementation.now(); |
| external static int _brokenDownDateToMillisecondsSinceEpoch( |
| int years, int month, int day, int hour, int minute, int second, |