Issue 10949011: Switch SadTabHelper to use WebContentsUserData.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10949011: Switch SadTabHelper to use WebContentsUserData. (Closed)

Created:
8 years, 3 months ago by Avi (use Gerrit)

Modified:
8 years, 3 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews, tfarina, Avi (use Gerrit), creis+watch_chromium.org, ajwong+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Switch SadTabHelper to use WebContentsUserData. BUG=107201 TEST=no visible change Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=157575

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -13 lines)			Patch
M	chrome/browser/ui/sad_tab_helper.h	View		3 chunks	+7 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/sad_tab_helper.cc	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/tab_contents/tab_contents.h	View	1	3 chunks	+0 lines, -4 lines	0 comments	Download
M	chrome/browser/ui/tab_contents/tab_contents.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/views/tab_contents/chrome_web_contents_view_delegate_views.cc	View	1	2 chunks	+9 lines, -6 lines	0 comments	Download

Total messages: 6 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/10949011/1

8 years, 3 months ago (2012-09-18 22:34:35 UTC) #3

commit-bot: I haz the power

Sorry for I got bad news for ya. Compile failed with a clobber build. Your ...

8 years, 3 months ago (2012-09-18 23:20:30 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/10949011/4002

8 years, 3 months ago (2012-09-19 15:36:37 UTC) #5

Change committed as 157575