Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 10949009: Fix breakage due to crrev.com/156530 (Closed)

Created:
8 years, 3 months ago by achuithb
Modified:
8 years, 3 months ago
CC:
chromium-reviews, dbeam+watch-ntp_chromium.org, estade+watch_chromium.org, arv (Not doing code reviews)
Visibility:
Public.

Description

Fix breakage due to crrev.com/156530 BUG=NONE TEST=no console log errors on ntp. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=157486

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/resources/ntp4/new_tab.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
achuithb
Please review.
8 years, 3 months ago (2012-09-18 22:26:29 UTC) #1
bartfab (slow)
LGTM Thanks for catching this. I had updated the login bubble but missed the promo ...
8 years, 3 months ago (2012-09-18 22:38:30 UTC) #2
Dan Beam
lgtm this is why we need to use closure compiler or have tests that show ...
8 years, 3 months ago (2012-09-18 22:44:44 UTC) #3
achuithb
On 2012/09/18 22:38:30, bartfab wrote: > LGTM > > Thanks for catching this. I had ...
8 years, 3 months ago (2012-09-18 22:46:44 UTC) #4
achuithb
On 2012/09/18 22:44:44, Dan Beam wrote: > lgtm this is why we need to use ...
8 years, 3 months ago (2012-09-18 22:49:56 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/achuith@chromium.org/10949009/1
8 years, 3 months ago (2012-09-18 22:59:07 UTC) #6
commit-bot: I haz the power
8 years, 3 months ago (2012-09-19 03:59:41 UTC) #7
Change committed as 157486

Powered by Google App Engine
This is Rietveld 408576698