Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(411)

Issue 10948048: [net] Increase HostCache size to 1000 entries on CrOS. (Closed)

Created:
5 years, 2 months ago by szym
Modified:
5 years, 2 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org, mmenke
Visibility:
Public.

Description

[net] Increase HostCache size to 1000 entries on CrOS. The built-in async DNS client notoriously fills up the small (100-entry) cache. To even out the playfield for the field trial, drastically increase the size. This is a temporary measure before we can tune the size according to performance. BUG=114277 TEST=on CrOS, check HostCache size in chrome://net-internals/#dns Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=157742

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M net/base/host_cache.cc View 1 chunk +7 lines, -0 lines 1 comment Download

Messages

Total messages: 5 (0 generated)
szym
5 years, 2 months ago (2012-09-19 22:56:45 UTC) #1
cbentzel
LGTM
5 years, 2 months ago (2012-09-20 10:03:11 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/szym@chromium.org/10948048/1
5 years, 2 months ago (2012-09-20 10:03:23 UTC) #3
commit-bot: I haz the power
Change committed as 157742
5 years, 2 months ago (2012-09-20 11:02:52 UTC) #4
jar (doing other things)
5 years, 2 months ago (2012-09-20 17:24:34 UTC) #5
Drive by...

https://chromiumcodereview.appspot.com/10948048/diff/1/net/base/host_cache.cc
File net/base/host_cache.cc (right):

https://chromiumcodereview.appspot.com/10948048/diff/1/net/base/host_cache.cc...
net/base/host_cache.cc:81: static const size_t kMaxHostCacheEntries = 100;
nit: static on these data items seems like a waste.  I hope the compiler gets
rid of this variable... but static might possibly confuse the issue.

Powered by Google App Engine
This is Rietveld 0eb02b776