Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Side by Side Diff: chrome/browser/ui/panels/panel_view.h

Issue 10948027: [Panels] Fix browser crash when killing extension on Windows. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_PANELS_PANEL_VIEW_H_ 5 #ifndef CHROME_BROWSER_UI_PANELS_PANEL_VIEW_H_
6 #define CHROME_BROWSER_UI_PANELS_PANEL_VIEW_H_ 6 #define CHROME_BROWSER_UI_PANELS_PANEL_VIEW_H_
7 7
8 #include "base/memory/scoped_ptr.h" 8 #include "base/memory/scoped_ptr.h"
9 #include "chrome/browser/ui/panels/native_panel.h" 9 #include "chrome/browser/ui/panels/native_panel.h"
10 #include "ui/base/animation/animation_delegate.h" 10 #include "ui/base/animation/animation_delegate.h"
(...skipping 132 matching lines...) Expand 10 before | Expand all | Expand 10 after
143 // |attribute_index|. This is used to update the style or extended style 143 // |attribute_index|. This is used to update the style or extended style
144 // for the native window. 144 // for the native window.
145 void UpdateWindowAttribute(int attribute_index, 145 void UpdateWindowAttribute(int attribute_index,
146 int attribute_value, 146 int attribute_value,
147 bool to_set); 147 bool to_set);
148 #endif 148 #endif
149 149
150 scoped_ptr<Panel> panel_; 150 scoped_ptr<Panel> panel_;
151 gfx::Rect bounds_; 151 gfx::Rect bounds_;
152 152
153 // The window that holds all panel views. 153 // The window that holds all panel views. Lifetime managed by native widget.
154 // See widget.h.
154 views::Widget* window_; 155 views::Widget* window_;
155 156
156 // The view hosting the web contents. 157 // The view hosting the web contents. Will be destroyed when child views
158 // of this class are destroyed.
157 views::WebView* web_view_; 159 views::WebView* web_view_;
158 160
159 // True if the panel should always stay on top of other windows. 161 // True if the panel should always stay on top of other windows.
160 bool always_on_top_; 162 bool always_on_top_;
161 163
162 // Is the panel receiving the focus? 164 // Is the panel receiving the focus?
163 bool focused_; 165 bool focused_;
164 166
165 // Is the mouse button currently down? 167 // Is the mouse button currently down?
166 bool mouse_pressed_; 168 bool mouse_pressed_;
(...skipping 24 matching lines...) Expand all
191 193
192 #if defined(OS_WIN) && !defined(USE_ASH) && !defined(USE_AURA) 194 #if defined(OS_WIN) && !defined(USE_ASH) && !defined(USE_AURA)
193 // Used to provide custom taskbar thumbnail for Windows 7 and later. 195 // Used to provide custom taskbar thumbnail for Windows 7 and later.
194 scoped_ptr<TaskbarWindowThumbnailerWin> thumbnailer_; 196 scoped_ptr<TaskbarWindowThumbnailerWin> thumbnailer_;
195 #endif 197 #endif
196 198
197 DISALLOW_COPY_AND_ASSIGN(PanelView); 199 DISALLOW_COPY_AND_ASSIGN(PanelView);
198 }; 200 };
199 201
200 #endif // CHROME_BROWSER_UI_PANELS_PANEL_VIEW_H_ 202 #endif // CHROME_BROWSER_UI_PANELS_PANEL_VIEW_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698