Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1254)

Issue 10948021: A crash fix: the entire implicated section seems obsolete. Removed. (Closed)

Created:
8 years, 3 months ago by motek.
Modified:
8 years, 3 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

A crash fix: removed the entire implicated section as obsolete. Note that the TODO points to a crbug which is declared obsolete / irrelevant. BUG=149729 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=157974

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -5 lines) Patch
M chrome/browser/ui/startup/startup_browser_creator_impl.cc View 1 chunk +1 line, -5 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
motek.
Could I trouble you for a review, Robert?
8 years, 3 months ago (2012-09-18 22:16:48 UTC) #1
robertshield
Code change lgtm, but I'm unsure as to whether this will cause visible side-effects in ...
8 years, 3 months ago (2012-09-18 23:52:37 UTC) #2
motek.
sky@, Could I trouble you with this very simple CL? I believe setfocus call to ...
8 years, 3 months ago (2012-09-19 14:53:48 UTC) #3
sky
How did you verify this is no longer needed?
8 years, 3 months ago (2012-09-19 17:04:53 UTC) #4
motek.
I obviously do not have conclusive proof, but: I followed the code path and tried ...
8 years, 3 months ago (2012-09-19 18:32:18 UTC) #5
sky
Jay is still around. Jay, any ideas?
8 years, 3 months ago (2012-09-19 21:03:54 UTC) #6
Jay Civelli
Sorry for the delay. I don't remember precisely, but if you can still move the ...
8 years, 3 months ago (2012-09-19 21:27:47 UTC) #7
motek.
On 2012/09/19 21:27:47, Jay Civelli wrote: > Sorry for the delay. > I don't remember ...
8 years, 3 months ago (2012-09-20 14:57:03 UTC) #8
sky
LGTM
8 years, 3 months ago (2012-09-20 15:31:55 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/motek@chromium.org/10948021/1
8 years, 3 months ago (2012-09-20 18:04:52 UTC) #10
commit-bot: I haz the power
Retried try job too often for step(s) browser_tests
8 years, 3 months ago (2012-09-21 05:21:37 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/motek@chromium.org/10948021/1
8 years, 3 months ago (2012-09-21 12:11:09 UTC) #12
commit-bot: I haz the power
8 years, 3 months ago (2012-09-21 13:56:12 UTC) #13
Change committed as 157974

Powered by Google App Engine
This is Rietveld 408576698