Convert native mouse locations to the locations in screen coordinate in RootWindowHostLinux.

Convert native mouse locations to the locations in screen coordinate in RootWindowHostLinux.

Once this CL is landed, event handlers do not need to be aware of native screen coordinates even when passive grab is taken.
All the conversions can be done only by way of screen coordinate.
This CL depends on http://codereview.chromium.org/10911342/.

BUG=148686, 148761, 146435, 146072
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=157720

[oshima, 2012-09-18 23:10:15]

http://codereview.chromium.org/10948020/diff/1/ash/display/mouse_cursor_event...
File ash/display/mouse_cursor_event_filter.cc (right):

http://codereview.chromium.org/10948020/diff/1/ash/display/mouse_cursor_event...
ash/display/mouse_cursor_event_filter.cc:89: wm::ConvertPointToScreen(target,
&point_in_screen);
does this work when this target is a capture window on other root window
(happens when menu is open, for example).

http://codereview.chromium.org/10948020/diff/1/ash/drag_drop/drag_drop_tracke...
File ash/drag_drop/drag_drop_tracker.cc (right):

http://codereview.chromium.org/10948020/diff/1/ash/drag_drop/drag_drop_tracke...
ash/drag_drop/drag_drop_tracker.cc:33: return
ash::wm::GetRootWindowAt(location_in_screen);
I'd prefer this to be different name than GetRootWindowAt
(GetRootWindowAtLocalPoint()), or just do it in ConvertMouseEvent as this is
used only once, and relatively short.

http://codereview.chromium.org/10948020/diff/1/ash/wm/workspace/workspace_win...
File ash/wm/workspace/workspace_window_resizer.cc (right):

http://codereview.chromium.org/10948020/diff/1/ash/wm/workspace/workspace_win...
ash/wm/workspace/workspace_window_resizer.cc:125: void
WorkspaceWindowResizer::Drag(const gfx::Point& location, int event_flags) {
can you specify the coordinates in name?

http://codereview.chromium.org/10948020/diff/1/ui/aura/root_window_host_linux.cc
File ui/aura/root_window_host_linux.cc (right):

http://codereview.chromium.org/10948020/diff/1/ui/aura/root_window_host_linux...
ui/aura/root_window_host_linux.cc:984: GetScreenPositionClient(GetRootWindow());
nit. assigning RootWindow to root would make it cleaner in this case.

http://codereview.chromium.org/10948020/diff/1/ui/aura/root_window_host_linux.h
File ui/aura/root_window_host_linux.h (right):

http://codereview.chromium.org/10948020/diff/1/ui/aura/root_window_host_linux...
ui/aura/root_window_host_linux.h:84: void
OnHostMouseEventInternal(ui::MouseEvent* event);
TranslateAndDispatchMouseEvent

(or something that indicates that that it's doing) would be better in this case.

[mazda, 2012-09-18 23:44:57]

I addressed all the comments. Please take another look.

http://codereview.chromium.org/10948020/diff/1/ash/display/mouse_cursor_event...
File ash/display/mouse_cursor_event_filter.cc (right):

http://codereview.chromium.org/10948020/diff/1/ash/display/mouse_cursor_event...
ash/display/mouse_cursor_event_filter.cc:89: wm::ConvertPointToScreen(target,
&point_in_screen);
On 2012/09/18 23:10:15, oshima wrote:
> does this work when this target is a capture window on other root window
> (happens when menu is open, for example).

Yes, it works.
event->location() is converted in RootWindowHostLinux and RootWindow to the
location taking into account the root window layout in screen coordinate.

http://codereview.chromium.org/10948020/diff/1/ash/drag_drop/drag_drop_tracke...
File ash/drag_drop/drag_drop_tracker.cc (right):

http://codereview.chromium.org/10948020/diff/1/ash/drag_drop/drag_drop_tracke...
ash/drag_drop/drag_drop_tracker.cc:33: return
ash::wm::GetRootWindowAt(location_in_screen);
On 2012/09/18 23:10:15, oshima wrote:
> I'd prefer this to be different name than GetRootWindowAt
> (GetRootWindowAtLocalPoint()), or just do it in ConvertMouseEvent as this is
> used only once, and relatively short.

Removed the function.

http://codereview.chromium.org/10948020/diff/1/ash/wm/workspace/workspace_win...
File ash/wm/workspace/workspace_window_resizer.cc (right):

http://codereview.chromium.org/10948020/diff/1/ash/wm/workspace/workspace_win...
ash/wm/workspace/workspace_window_resizer.cc:125: void
WorkspaceWindowResizer::Drag(const gfx::Point& location, int event_flags) {
On 2012/09/18 23:10:15, oshima wrote:
> can you specify the coordinates in name?

Done.

http://codereview.chromium.org/10948020/diff/1/ui/aura/root_window_host_linux.cc
File ui/aura/root_window_host_linux.cc (right):

http://codereview.chromium.org/10948020/diff/1/ui/aura/root_window_host_linux...
ui/aura/root_window_host_linux.cc:984: GetScreenPositionClient(GetRootWindow());
On 2012/09/18 23:10:15, oshima wrote:
> nit. assigning RootWindow to root would make it cleaner in this case.

Done.

http://codereview.chromium.org/10948020/diff/1/ui/aura/root_window_host_linux.h
File ui/aura/root_window_host_linux.h (right):

http://codereview.chromium.org/10948020/diff/1/ui/aura/root_window_host_linux...
ui/aura/root_window_host_linux.h:84: void
OnHostMouseEventInternal(ui::MouseEvent* event);
On 2012/09/18 23:10:15, oshima wrote:
> TranslateAndDispatchMouseEvent
> 
> (or something that indicates that that it's doing) would be better in this
case.

Done.

[oshima, 2012-09-18 23:51:55]

thanks, this is awesome. Much simpler and nicer.

LGTM

[mazda, 2012-09-19 03:55:09]

+sky
Could you do an OWNERS review for ash, ui/aura and ui?

[sky, 2012-09-19 14:08:53]

Nice cleanup. LGTM

[commit-bot: I haz the power, 2012-09-20 01:17:50]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mazda@chromium.org/10948020/6003

[commit-bot: I haz the power, 2012-09-20 01:48:09]

Sorry for I got bad news for ya.
Compile failed with a clobber build.
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2012-09-20 05:23:35]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mazda@chromium.org/10948020/19001

[commit-bot: I haz the power, 2012-09-20 07:15:23]

Change committed as 157720