chrome/browser/system_monitor/removable_device_notifications_mac_unittest.mm - Issue 10948019: Remove use of weakptr for RemovableDeviceNotificationsMac

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/system_monitor/removable_device_notifications_mac_unittest.mm

Issue 10948019: Remove use of weakptr for RemovableDeviceNotificationsMac (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/system_monitor/removable_device_notifications_mac.mm ('K') | « chrome/browser/system_monitor/removable_device_notifications_mac.mm ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/system_monitor/removable_device_notifications_mac_unittest.mm

diff --git a/chrome/browser/system_monitor/removable_device_notifications_mac_unittest.mm b/chrome/browser/system_monitor/removable_device_notifications_mac_unittest.mm

index 9a3cc9fa322e994eaf079e9956179500781bd81f..65d81f987b733dc060f4131134858af23756f177 100644

--- a/chrome/browser/system_monitor/removable_device_notifications_mac_unittest.mm

+++ b/chrome/browser/system_monitor/removable_device_notifications_mac_unittest.mm

@@ -55,7 +55,7 @@ class RemovableDeviceNotificationsMacTest : public testing::Test {

system_monitor_->AddDevicesChangedObserver(

mock_devices_changed_observer_.get());

- notifications_.reset(new RemovableDeviceNotificationsMac);

+ notifications_ = new RemovableDeviceNotificationsMac;

unique_id_ = "test_id";

display_name_ = ASCIIToUTF16("Test Display Name");

@@ -81,7 +81,7 @@ class RemovableDeviceNotificationsMacTest : public testing::Test {

std::string device_id_;

DiskInfoMac disk_info_;

- scoped_ptr<RemovableDeviceNotificationsMac> notifications_;

+ scoped_refptr<RemovableDeviceNotificationsMac> notifications_;

};

TEST_F(RemovableDeviceNotificationsMacTest, AddRemove) {