Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10947042: Fixing spelling service to use GetAPIKey. (Closed)

Created:
8 years, 3 months ago by rpetterson
Modified:
8 years, 3 months ago
Reviewers:
groby-ooo-7-16, Jói
CC:
chromium-reviews, darin-cc_chromium.org, Hironori Bono
Visibility:
Public.

Description

Fixing spelling service to use GetAPIKey. BUG=150906 TBR=hbono@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=157869

Patch Set 1 #

Patch Set 2 : cleaning up change #

Patch Set 3 : cleaning up change #

Patch Set 4 : removing cruft #

Patch Set 5 : removing unnecessary line #

Total comments: 1

Patch Set 6 : Updating unit_test to reflect change in country format. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -17 lines) Patch
M chrome/browser/spellchecker/spelling_service_client.cc View 1 2 3 4 2 chunks +5 lines, -16 lines 0 comments Download
M chrome/browser/spellchecker/spelling_service_client_unittest.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
rpetterson
8 years, 3 months ago (2012-09-19 22:43:50 UTC) #1
groby-ooo-7-16
lgtm http://codereview.chromium.org/10947042/diff/7001/chrome/browser/spellchecker/spelling_service_client.cc File chrome/browser/spellchecker/spelling_service_client.cc (right): http://codereview.chromium.org/10947042/diff/7001/chrome/browser/spellchecker/spelling_service_client.cc#newcode90 chrome/browser/spellchecker/spelling_service_client.cc:90: api_key.c_str()); Oh. Now I see it :)
8 years, 3 months ago (2012-09-19 23:06:05 UTC) #2
Jói
LGTM
8 years, 3 months ago (2012-09-20 10:28:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rlp@chromium.org/10947042/7001
8 years, 3 months ago (2012-09-20 17:38:36 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rlp@chromium.org/10947042/18001
8 years, 3 months ago (2012-09-20 21:18:21 UTC) #5
commit-bot: I haz the power
8 years, 3 months ago (2012-09-20 23:21:59 UTC) #6 
Change committed as 157869

Powered by Google App Engine
This is Rietveld 408576698