Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Unified Diff: sync/engine/sync_scheduler_impl.cc

Issue 10947039: Removed safe worker calculation from SyncScheduler. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Removed variable active_groups that was no longer needed. Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sync/engine/sync_scheduler_impl.cc
diff --git a/sync/engine/sync_scheduler_impl.cc b/sync/engine/sync_scheduler_impl.cc
index d5f9dfff1f84f569d5704992240494ab757a7069..82cdcce1c203a7da0c19c1104b1613113c012fac 100644
--- a/sync/engine/sync_scheduler_impl.cc
+++ b/sync/engine/sync_scheduler_impl.cc
@@ -300,16 +300,12 @@ void SyncSchedulerImpl::SendInitialSnapshot() {
namespace {
-// Helper to extract the routing info and workers corresponding to types in
-// |types| from |current_routes| and |current_workers|.
+// Helper to extract the routing info corresponding to types in
+// |types| from |current_routes|.
void BuildModelSafeParams(
ModelTypeSet types_to_download,
const ModelSafeRoutingInfo& current_routes,
- const std::vector<ModelSafeWorker*>& current_workers,
- ModelSafeRoutingInfo* result_routes,
- std::vector<ModelSafeWorker*>* result_workers) {
- std::set<ModelSafeGroup> active_groups;
- active_groups.insert(GROUP_PASSIVE);
+ ModelSafeRoutingInfo* result_routes) {
for (ModelTypeSet::Iterator iter = types_to_download.First(); iter.Good();
iter.Inc()) {
ModelType type = iter.Get();
@@ -317,13 +313,6 @@ void BuildModelSafeParams(
DCHECK(route != current_routes.end());
ModelSafeGroup group = route->second;
(*result_routes)[type] = group;
- active_groups.insert(group);
- }
-
- for(std::vector<ModelSafeWorker*>::const_iterator iter =
- current_workers.begin(); iter != current_workers.end(); ++iter) {
- if (active_groups.count((*iter)->GetModelSafeGroup()) > 0)
- result_workers->push_back(*iter);
}
}
@@ -341,16 +330,10 @@ bool SyncSchedulerImpl::ScheduleConfiguration(
// for a pending configure job.
DCHECK(!wait_interval_.get() || !wait_interval_->pending_configure_job.get());
- // TODO(sync): now that ModelChanging commands only use those workers within
- // the routing info, we don't really need |restricted_workers|. Remove it.
- // crbug.com/133030
ModelSafeRoutingInfo restricted_routes;
- std::vector<ModelSafeWorker*> restricted_workers;
BuildModelSafeParams(params.types_to_download,
params.routing_info,
- session_context_->workers(),
- &restricted_routes,
- &restricted_workers);
+ &restricted_routes);
session_context_->set_routing_info(params.routing_info);
// Only reconfigure if we have types to download.
@@ -364,7 +347,7 @@ bool SyncSchedulerImpl::ScheduleConfiguration(
restricted_routes,
std::string())),
restricted_routes,
- restricted_workers));
+ session_context_->workers()));
SyncSessionJob job(SyncSessionJob::CONFIGURATION,
TimeTicks::Now(),
session,
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698