chrome/test/data/extensions/api_test/debugger/background.js - Issue 10947037: DevTools: provide the debugger detach reason in chrome.debugger.onDetach extension API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/data/extensions/api_test/debugger/background.js

Issue 10947037: DevTools: provide the debugger detach reason in chrome.debugger.onDetach extension API. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Reviewer comments addressed. Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/test/data/extensions/api_test/debugger/background.js

diff --git a/chrome/test/data/extensions/api_test/debugger/background.js b/chrome/test/data/extensions/api_test/debugger/background.js

index 06f3b7df4150efb99164d8a1e8e0373d137a926e..2711837b4d5d5a28a19e01834cb3f132651a826a 100644

--- a/chrome/test/data/extensions/api_test/debugger/background.js

+++ b/chrome/test/data/extensions/api_test/debugger/background.js

@@ -69,8 +69,9 @@ chrome.test.runTests([

function closeTab() {

chrome.tabs.create({url:"inspected.html"}, function(tab) {

- function onDetach(debuggee) {

+ function onDetach(debuggee, reason) {

chrome.test.assertEq(tab.id, debuggee.tabId);

+ chrome.test.assertEq("target_closed", reason);

chrome.debugger.onDetach.removeListener(onDetach);

chrome.test.succeed();

}

« no previous file with comments | « chrome/common/extensions/api/debugger.json ('k') | no next file » | no next file with comments »