Issue 10947037: DevTools: provide the debugger detach reason in chrome.debugger.onDetach extension API.

Issue 10947037: DevTools: provide the debugger detach reason in chrome.debugger.onDetach extension API. (Closed)

Created:
8 years, 3 months ago by pfeldman

Modified:
8 years, 3 months ago

Reviewers:
Matt Perry, yurys

CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

DevTools: provide the debugger detach reason in chrome.debugger.onDetach extension API. BUG=129539 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=157754

Patch Set 3 : Reviewer comments addressed. #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+89 lines, -9 lines)			Patch
M	chrome/browser/debugger/devtools_window.cc	View		2 chunks	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/extensions/api/debugger/debugger_api.h	View		2 chunks	+9 lines, -0 lines	0 comments	Download
M	chrome/browser/extensions/api/debugger/debugger_api.cc	View	1 2	12 chunks	+70 lines, -8 lines	0 comments	Download
M	chrome/common/extensions/api/debugger.json	View		1 chunk	+6 lines, -0 lines	0 comments	Download
M	chrome/test/data/extensions/api_test/debugger/background.js	View		1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

pfeldman

@mpcomplete: this is a small change that adds new parameter to the debugger onDetach event. ...

8 years, 3 months ago (2012-09-19 18:25:26 UTC) #2

Matt Perry

lgtm https://chromiumcodereview.appspot.com/10947037/diff/2001/chrome/browser/extensions/api/debugger/debugger_api.cc File chrome/browser/extensions/api/debugger/debugger_api.cc (right): https://chromiumcodereview.appspot.com/10947037/diff/2001/chrome/browser/extensions/api/debugger/debugger_api.cc#newcode68 chrome/browser/extensions/api/debugger/debugger_api.cc:68: void DiscardClientHost(); Please comment this method. https://chromiumcodereview.appspot.com/10947037/diff/2001/chrome/browser/extensions/api/debugger/debugger_api.cc#newcode102 chrome/browser/extensions/api/debugger/debugger_api.cc:102: ...

8 years, 3 months ago (2012-09-19 19:14:13 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pfeldman@chromium.org/10947037/12001

8 years, 3 months ago (2012-09-20 11:10:11 UTC) #5

Change committed as 157754

Expand Messages | Collapse Messages