Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Unified Diff: lib/compiler/implementation/universe/universe.dart

Issue 10947024: Made dart2js constructor lookup logic "private"-aware, fixed 4740 bug. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Removed normalizedConstructorName from Selector. Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: lib/compiler/implementation/universe/universe.dart
diff --git a/lib/compiler/implementation/universe/universe.dart b/lib/compiler/implementation/universe/universe.dart
index ef9500b56b45f9cb9801bee93a26fcc0863ec3ab..e3af6daa0f6a7ee055040e204182dd77fa38dbdc 100644
--- a/lib/compiler/implementation/universe/universe.dart
+++ b/lib/compiler/implementation/universe/universe.dart
@@ -187,6 +187,18 @@ class Selector {
: this(SelectorKind.CALL, Compiler.CALL_OPERATOR_NAME, null,
selector.argumentCount, selector.namedArguments);
+ Selector.callConstructor(SourceString constructorName,
+ LibraryElement library)
+ : this(SelectorKind.CALL,
+ constructorName,
+ library,
+ 0,
+ const []);
+
+ Selector.callDefaultConstructor(SourceString name,
kasperl 2012/10/09 13:56:02 What's the name in this case? Shouldn't it always
aam-me 2012/10/10 00:22:40 Good point, thanks. I also have been using callDef
+ LibraryElement library)
+ : this(SelectorKind.CALL, name, library, 0, const []);
+
// TODO(kasperl): This belongs somewhere else.
Selector.noSuchMethod()
: this(SelectorKind.CALL, Compiler.NO_SUCH_METHOD, null, 2);

Powered by Google App Engine
This is Rietveld 408576698