lib/compiler/implementation/ssa/builder.dart - Issue 10947024: Made dart2js constructor lookup logic "private"-aware, fixed 4740 bug.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: lib/compiler/implementation/ssa/builder.dart

Issue 10947024: Made dart2js constructor lookup logic "private"-aware, fixed 4740 bug. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Removed normalizedConstructorName from Selector. Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« lib/compiler/implementation/resolver.dart ('K') | « lib/compiler/implementation/resolver.dart ('k') | lib/compiler/implementation/universe/universe.dart » ('j') | lib/compiler/implementation/universe/universe.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: lib/compiler/implementation/ssa/builder.dart

diff --git a/lib/compiler/implementation/ssa/builder.dart b/lib/compiler/implementation/ssa/builder.dart

index 91d2d4567f85ebd1833377a4054c31adfc32ae60..ea435643c03bb15cb4c802e8047b9b8eab8cc54a 100644

--- a/lib/compiler/implementation/ssa/builder.dart

+++ b/lib/compiler/implementation/ssa/builder.dart

@@ -1211,9 +1211,10 @@ class SsaBuilder extends ResolvedVisitor implements Visitor {

assert(superClass !== null);

assert(superClass.resolutionState == STATE_DONE);

Selector selector =

- new Selector.call(superClass.name, enclosingClass.getLibrary(), 0);

+ new Selector.callDefaultConstructor(superClass.name,

+ enclosingClass.getLibrary());

// TODO(johnniwinther): Should we find injected constructors as well?

- FunctionElement target = superClass.lookupConstructor(superClass.name);

+ FunctionElement target = superClass.lookupConstructor(selector);

if (target === null) {

compiler.internalError("no default constructor available");

}