tests/compiler/dart2js/resolver_test.dart - Issue 10947024: Made dart2js constructor lookup logic "private"-aware, fixed 4740 bug.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests/compiler/dart2js/resolver_test.dart

Issue 10947024: Made dart2js constructor lookup logic "private"-aware, fixed 4740 bug. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Another attempt at implementing private-aware constructor lookup logic - with normalized constructo… Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tests/compiler/dart2js/resolver_test.dart

diff --git a/tests/compiler/dart2js/resolver_test.dart b/tests/compiler/dart2js/resolver_test.dart

index 726d37fe09cb80bce40eeeb2ae65637cd22c0a5d..b216e895151ccd32e80d55f5481eb7ac88ec374e 100644

--- a/tests/compiler/dart2js/resolver_test.dart

+++ b/tests/compiler/dart2js/resolver_test.dart

@@ -562,8 +562,9 @@ resolveConstructor(String script, String statement, String className,

compiler.resolveStatement(statement);

ClassElement classElement =

compiler.mainApp.find(buildSourceString(className));

- Element element =

- classElement.lookupConstructor(buildSourceString(constructor));

+ classElement.lookupConstructor(

+ new Selector.callDefaultConstructor(buildSourceString(constructor),

+ statement.getLibrary());

FunctionExpression tree = element.parseNode(compiler);

ResolverVisitor visitor = new ResolverVisitor(compiler, element);

new InitializerResolver(visitor).resolveInitializers(element, tree);

« lib/compiler/implementation/resolver.dart ('K') | « tests/co19/co19-dart2js.status ('k') | tests/compiler/dart2js_extra/dart2js_extra.status » ('j') | no next file with comments »