Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(518)

Unified Diff: lib/compiler/implementation/compile_time_constants.dart

Issue 10947024: Made dart2js constructor lookup logic "private"-aware, fixed 4740 bug. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Another attempt at implementing private-aware constructor lookup logic - with normalized constructo… Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: lib/compiler/implementation/compile_time_constants.dart
diff --git a/lib/compiler/implementation/compile_time_constants.dart b/lib/compiler/implementation/compile_time_constants.dart
index 411b90b11eaf76e8d644e8876d97808aa31705ea..a4d4cf2ad956308ceac705cc65fe84657fef19f4 100644
--- a/lib/compiler/implementation/compile_time_constants.dart
+++ b/lib/compiler/implementation/compile_time_constants.dart
@@ -769,16 +769,17 @@ class ConstructorEvaluator extends CompileTimeConstantEvaluator {
if (enclosingClass != compiler.objectClass) {
assert(superClass !== null);
assert(superClass.resolutionState == STATE_DONE);
+
+ Selector selector =
+ new Selector.callDefaultConstructor(superClass.name,
+ enclosingClass.getLibrary());
FunctionElement targetConstructor =
- superClass.lookupConstructor(superClass.name);
+ superClass.lookupConstructor(selector);
if (targetConstructor === null) {
compiler.internalError("no default constructor available",
node: functionNode);
}
- Selector selector = new Selector.call(superClass.name,
- enclosingClass.getLibrary(),
- 0);
evaluateSuperOrRedirectSend(functionNode,
selector,
const EmptyLink<Node>(),
« no previous file with comments | « no previous file | lib/compiler/implementation/elements/elements.dart » ('j') | lib/compiler/implementation/resolver.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698