lib/compiler/implementation/dart_backend/placeholder_collector.dart - Issue 10947024: Made dart2js constructor lookup logic "private"-aware, fixed 4740 bug.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: lib/compiler/implementation/dart_backend/placeholder_collector.dart

Issue 10947024: Made dart2js constructor lookup logic "private"-aware, fixed 4740 bug. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« lib/compiler/implementation/compile_time_constants.dart ('K') | « lib/compiler/implementation/compile_time_constants.dart ('k') | lib/compiler/implementation/elements/elements.dart » ('j') | lib/compiler/implementation/elements/elements.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: lib/compiler/implementation/dart_backend/placeholder_collector.dart

diff --git a/lib/compiler/implementation/dart_backend/placeholder_collector.dart b/lib/compiler/implementation/dart_backend/placeholder_collector.dart

index 21d08ced41747468a001ae963d6ed3cc23a257c1..c56bbbfc115ff5df71bfaa6a0c94028ed445c3c0 100644

--- a/lib/compiler/implementation/dart_backend/placeholder_collector.dart

+++ b/lib/compiler/implementation/dart_backend/placeholder_collector.dart

@@ -446,7 +446,9 @@ class PlaceholderCollector extends AbstractVisitor {

if (element is TypedefElement) return true;

ClassElement classElement = element;

final constructor = classElement.lookupConstructor(

- receiver.source, selector.source);

+ currentElement.getLibrary(),

+ receiver.source,

+ selector.source);

return constructor === null;

}

if (!hasPrefix()) target = send.receiver;