Made dart2js constructor lookup logic "private"-aware, fixed 4740 bug.

tests/co19/co19-dart2js.status

 # Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 # for details. All rights reserved. Use of this source code is governed by a
 # BSD-style license that can be found in the LICENSE file.
 
 
 # Crashes first, please. Then untriaged bugs. There is a section below
 # for co19 bugs.
 [ $compiler == dart2js ]
 Language/07_Classes/6_Constructors/2_Factories_A01_t01: Crash # http://dartbug.com/5017
 Language/13_Libraries_and_Scripts/2_Imports_A03_t07: Crash # http://dartbug.com/5429
@@ skipping 235 matching lines @@
 
 [ $compiler == dart2js && $system == macos && $runtime == d8 ]
 LibTest/core/Math/acos_A01_t01: Fail, OK
 LibTest/core/Math/asin_A01_t01: Fail, OK
 LibTest/core/Math/atan_A01_t01: Fail, OK
 
 [ $compiler == dart2js && $system == windows && $runtime == d8 ]
 LibTest/core/double/operator_remainder_A01_t04: Fail
 
 [ $compiler == dart2js ]
+Language/07_Classes/6_Constructors/1_Generative_Constructors_A16_t07: Fail # Redirecting constructors can not use initializing formals. This bug was previously masked - compilation failed, but for different, wrong reason.

[ahe, 2012/10/11 04:55:40]

Is this a co19 bug?

[aam-me, 2012/10/11 06:14:00]

No, it is not. It is dart2js bug as far as I can tell.

+
 Language/06_Functions/2_Formal_Parameters/2_Optional_Formals_A01_t10: Fail # TODO(ahe): Enforce optional parameter semantics.
 Language/06_Functions/2_Formal_Parameters/2_Optional_Formals_A01_t11: Fail # TODO(ahe): Enforce optional parameter semantics.
 Language/06_Functions/2_Formal_Parameters/2_Optional_Formals_A03_t03: Fail # TODO(ahe): Enforce optional parameter semantics.
 Language/06_Functions/2_Formal_Parameters/2_Optional_Formals_A03_t04: Fail # TODO(ahe): Enforce optional parameter semantics.
 
 Language/10_Expressions/14_Function_Invocation/2_Binding_Actuals_to_Formals_A06_t01: Fail # Compile-time error: Unimplemented non-matching static call
 Language/10_Expressions/14_Function_Invocation/2_Binding_Actuals_to_Formals_A06_t04: Fail # Compile-time error: Unimplemented non-matching static call
 Language/10_Expressions/14_Function_Invocation/2_Binding_Actuals_to_Formals_A06_t05: Fail # Compile-time error: Unimplemented non-matching static call
 Language/10_Expressions/14_Function_Invocation/2_Binding_Actuals_to_Formals_A06_t08: Fail # Compile-time error: Unimplemented non-matching static call
 Language/10_Expressions/14_Function_Invocation/2_Binding_Actuals_to_Formals_A07_t01: Fail # Compile-time error: Unimplemented non-matching static call
@@ skipping 125 matching lines @@
 Language/11_Statements/09_Try_A06_t03: Fail, OK # co19 issue 194
 Language/11_Statements/09_Try_A06_t04: Fail, OK # co19 issue 194
 Language/11_Statements/09_Try_A06_t05: Fail, OK # co19 issue 194
 
 Language/06_Functions/4_External_Functions_A01_t01: Fail, OK # http://dartbug.com/5021
 
 Language/07_Classes/4_Abstract_Instance_Members_A02_t01: Fail, OK # co19 issue 195
 
 Language/03_Overview/2_Privacy_A01_t09: Fail, OK # co19 issue 198
 Language/03_Overview/2_Privacy_A01_t10: Fail, OK # co19 issue 198
-Language/03_Overview/2_Privacy_A01_t19: Fail, OK # co19 issue 198
-Language/03_Overview/2_Privacy_A01_t20: Fail, OK # co19 issue 198
 
 Language/10_Expressions/30_Type_Cast_A02_t03: Fail, OK # co19 issue 236
 
 Language/13_Libraries_and_Scripts/2_Imports_A03_t06: Fail, OK # co19 issue 244
 
 Language/13_Libraries_and_Scripts/2_Imports_A02_t01: Fail, OK # co19 issue 246
 Language/13_Libraries_and_Scripts/2_Imports_A02_t02: Fail, OK # co19 issue 246
 Language/13_Libraries_and_Scripts/2_Imports_A02_t16: Fail, OK # co19 issue 246
 Language/13_Libraries_and_Scripts/2_Imports_A02_t17: Fail, OK # co19 issue 246
 Language/13_Libraries_and_Scripts/2_Imports_A02_t20: Fail, OK # co19 issue 246
@@ skipping 359 matching lines @@
 Language/14_Types/4_Interface_Types_A10_t01: Fail # http://dartbug.com/5020
 Language/14_Types/4_Interface_Types_A10_t02: Fail # http://dartbug.com/5020
 Language/14_Types/4_Interface_Types_A10_t03: Fail # http://dartbug.com/5020
 Language/14_Types/4_Interface_Types_A10_t04: Fail # http://dartbug.com/5020
 Language/14_Types/4_Interface_Types_A10_t07: Fail # http://dartbug.com/5020
 Language/14_Types/4_Interface_Types_A11_t02: Fail # http://dartbug.com/5020
 Language/14_Types/4_Interface_Types_A12_t09: Fail # http://dartbug.com/5020
 Language/14_Types/4_Interface_Types_A12_t10: Fail # http://dartbug.com/5020
 Language/14_Types/4_Interface_Types_A12_t14: Fail # http://dartbug.com/5020
 Language/14_Types/4_Interface_Types_A12_t16 :Fail # http://dartbug.com/5020