tests/compiler/dart2js_extra/4740_int_library.dart - Issue 10947024: Made dart2js constructor lookup logic "private"-aware, fixed 4740 bug.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: tests/compiler/dart2js_extra/4740_int_library.dart

Issue 10947024: Made dart2js constructor lookup logic "private"-aware, fixed 4740 bug. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Another try in implementing constructor lookup, without SelectorName this time. Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file	1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file

2 // for details. All rights reserved. Use of this source code is governed by a	2 // for details. All rights reserved. Use of this source code is governed by a

3 // BSD-style license that can be found in the LICENSE file.	3 // BSD-style license that can be found in the LICENSE file.

4	4

5 #library('4740_library');	5 #library('4740_int_library');

6	6

7 class Foo {	7 class Foo implements FooInterface {

8 Foo._internal();	8 Foo._internal();

9 }	9 }

	10

	11 interface FooInterface default Foo {
	ahe 2012/09/24 06:43:31 Interfaces and default clauses are going away in M Interfaces and default clauses are going away in M1. How much of this change is needed to support deprecated features? aam-me 2012/09/24 13:08:20 Good point. Initial 4740 bug didn't concern interf Good point. Initial 4740 bug didn't concern interfaces. I added interfaces later for better coverage. Should I take them out?
	12 FooInterface._internal();

	13 }

OLD	NEW