Made dart2js constructor lookup logic "private"-aware, fixed 4740 bug.

lib/compiler/implementation/dart_backend/placeholder_collector.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 class LocalPlaceholder implements Hashable {
   final String identifier;
   final Set<Node> nodes;
   LocalPlaceholder(this.identifier) : nodes = new Set<Node>();
   int hashCode() => identifier.hashCode();
   String toString() =>
@@ skipping 428 matching lines @@
       if (node.typeName is Send) {
         final element = treeElements[node];
         if (element !== null) {
           final send = node.typeName.asSend();
           Identifier receiver = send.receiver;
           Identifier selector = send.selector;
           hasPrefix() {
             if (element is TypedefElement) return true;
             ClassElement classElement = element;
             final constructor = classElement.lookupConstructor(
-                receiver.source, selector.source);
+              new Selector.callConstructor(receiver.source, // class name

[kasperl, 2012/09/24 05:52:38]

Maybe add two local variables (className and constructorName) to avoid having to
add these end-of-line comments?

4 space indent.

[ahe, 2012/09/24 06:43:31]

This code does not belong in the dart_backend to begin with. I don't think we
should modify this code or try to get it to work. The dart backend should not do
resolution, or attempt to implement features that we have not yet implemented in
the front-end.

If this code breaks, so be it. I do not want to waste time on two resolvers.

[aam-me, 2012/09/25 04:15:18]

Okay, I removed this file from the changelist.

+                                           selector.source, // constructor name
+                                           currentElement.getLibrary()));
             return constructor === null;
           }
           if (!hasPrefix()) target = send.receiver;
         }
       }
       // TODO(antonm): is there a better way to detect unresolved types?
       if (type.element !== compiler.types.dynamicType.element) {
         makeTypePlaceholder(target, type);
       } else {
         if (!isDynamicType(node)) makeUnresolvedPlaceholder(target);
@@ skipping 134 matching lines @@
 
   visitBlock(Block node) {
     for (Node statement in node.statements.nodes) {
       if (statement is VariableDefinitions) {
         makeVarDeclarationTypePlaceholder(statement);
       }
     }
     node.visitChildren(this);
   }
 }