Constrained Window Cocoa: Disable fullscreen

Constrained Window Cocoa: Disable fullscreen

This CL prevents windows from entering or exiting fullscreen if a constrained window is attached.

BUG=146451
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=166410

[Robert Sesek, 2012-09-19 15:06:15]

Is this CL urgent? If not, I'm going to ask to hold off on this. I have two
large changes that affect fullscreen, and I can't really reason about this CL
until I make these other, significant logic changes.

[sail, 2012-09-19 16:53:29]

On 2012/09/19 15:06:15, rsesek wrote:
> Is this CL urgent? If not, I'm going to ask to hold off on this. I have two
> large changes that affect fullscreen, and I can't really reason about this CL
> until I make these other, significant logic changes.

Hey Robert! This CL can definitely wait. I'll start enabling the new constrained
windows UI by default end of next week. We can wait till after that to land
this.

Thanks!

[sail, 2012-10-23 17:13:35]

Ping! This needs to land by end of week. Thanks.

[Robert Sesek, 2012-11-05 21:17:32]

LGTM

https://codereview.chromium.org/10947019/diff/1/chrome/browser/ui/browser_com...
File chrome/browser/ui/browser_command_controller.cc (right):

https://codereview.chromium.org/10947019/diff/1/chrome/browser/ui/browser_com...
chrome/browser/ui/browser_command_controller.cc:1098: fullscreen_enabled =
fullscreen_enabled && !has_blocked_tab;
Could use &= here

[sail, 2012-11-06 22:00:43]

+sky for browser/ui OWNERS review

https://codereview.chromium.org/10947019/diff/1/chrome/browser/ui/browser_com...
File chrome/browser/ui/browser_command_controller.cc (right):

https://codereview.chromium.org/10947019/diff/1/chrome/browser/ui/browser_com...
chrome/browser/ui/browser_command_controller.cc:1098: fullscreen_enabled =
fullscreen_enabled && !has_blocked_tab;
On 2012/11/05 21:17:32, rsesek wrote:
> Could use &= here

Done.

[sky, 2012-11-07 00:25:39]

https://codereview.chromium.org/10947019/diff/7001/chrome/browser/ui/tabs/tab...
File chrome/browser/ui/tabs/tab_strip_model.cc (right):

https://codereview.chromium.org/10947019/diff/7001/chrome/browser/ui/tabs/tab...
chrome/browser/ui/tabs/tab_strip_model.cc:588: int
TabStripModel::IndexOfFirstBlockedTab() const {
See tab_strip_model_utils. It has this function.

[sail, 2012-11-07 00:58:48]

https://codereview.chromium.org/10947019/diff/7001/chrome/browser/ui/tabs/tab...
File chrome/browser/ui/tabs/tab_strip_model.cc (right):

https://codereview.chromium.org/10947019/diff/7001/chrome/browser/ui/tabs/tab...
chrome/browser/ui/tabs/tab_strip_model.cc:588: int
TabStripModel::IndexOfFirstBlockedTab() const {
On 2012/11/07 00:25:39, sky wrote:
> See tab_strip_model_utils. It has this function.

Done.
Good catch. Fixed.

[sky, 2012-11-07 04:57:52]

LGTM

[commit-bot: I haz the power, 2012-11-07 08:12:11]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sail@chromium.org/10947019/9007

[commit-bot: I haz the power, 2012-11-07 13:44:53]

Change committed as 166410