Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(327)

Issue 10947013: [OSX] All Flapper, all the time. (Closed)

Created:
8 years, 3 months ago by Scott Hess - ex-Googler
Modified:
8 years, 2 months ago
Reviewers:
brettw, sail, viettrungluu
CC:
chromium-reviews
Visibility:
Public.

Description

[OSX] All Flapper, all the time. No channel restriction on OSX Flapper. Fingers crossed. BUG=115437 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=158735

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -19 lines) Patch
M chrome/common/pepper_flash.cc View 2 chunks +2 lines, -19 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
Scott Hess - ex-Googler
Oops, forgot to post this.
8 years, 3 months ago (2012-09-18 20:53:22 UTC) #1
sail
LGTM!
8 years, 3 months ago (2012-09-18 20:55:49 UTC) #2
viettrungluu
lgtm
8 years, 3 months ago (2012-09-18 21:23:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shess@chromium.org/10947013/1
8 years, 3 months ago (2012-09-19 22:22:13 UTC) #4
commit-bot: I haz the power
Presubmit check for 10947013-1 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 3 months ago (2012-09-19 22:22:15 UTC) #5
Scott Hess - ex-Googler
On 2012/09/19 22:22:15, I haz the power (commit-bot) wrote: > Presubmit check for 10947013-1 failed ...
8 years, 3 months ago (2012-09-19 22:38:56 UTC) #6
viettrungluu
You'll need to merge this to M23. On 2012/09/19 22:38:56, shess wrote: > On 2012/09/19 ...
8 years, 3 months ago (2012-09-19 22:53:46 UTC) #7
Scott Hess - ex-Googler
Crap - I must have had an autocomplete fail or something - Brett, I need ...
8 years, 2 months ago (2012-09-25 13:06:01 UTC) #8
brettw
lgtm
8 years, 2 months ago (2012-09-25 18:19:39 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shess@chromium.org/10947013/1
8 years, 2 months ago (2012-09-25 19:25:13 UTC) #10
commit-bot: I haz the power
Retried try job too often for step(s) build
8 years, 2 months ago (2012-09-25 19:34:21 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shess@chromium.org/10947013/1
8 years, 2 months ago (2012-09-25 23:38:03 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shess@chromium.org/10947013/1
8 years, 2 months ago (2012-09-26 00:12:11 UTC) #13
commit-bot: I haz the power
8 years, 2 months ago (2012-09-26 03:12:53 UTC) #14
Change committed as 158735

Powered by Google App Engine
This is Rietveld 408576698