Chromium Code Reviews
DescriptionF4 behavior was change to maximize (from fullscreen). The label text needs to be changed, too.
Note from mazda@
keyboard_overlay_data.js is generated by tools/gen_keyboard_overaly_data/gen_keyboard_overlay_data.py
Necessary changes are:
1. Replace 'full screen' with 'maximize' in gen_keyboard_overlay_data.py
2. Replace 'full screen' with 'maximize' in keyboard_overlay.js
3. Regenerate keyboard_overlay_data.js by running gen_keyboard_overlay_data.py
However, currently step 3 does not work properly because of some manual changes of data.
In this case, I think it's OK just to replace all 'full screen' with 'maximize' in keyboard_overlay_data.js.
The key descriptions on the top row of keyboard overlay are currently not translated (might be better to translate though).
See also crbug.com/145402.
BUG=150785
TEST=Bring up keyboard overlay and observer label for "F4"
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=158084
Patch Set 1 #
Total comments: 1
Patch Set 2 : fix for Alt & Ctrl #
Messages
Total messages: 11 (0 generated)
|
|||||||||||||||||||||||||||||||||||||