Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 10946043: Change text in keyboard overlay from fullscreen to maximize (Closed)

Created:
8 years, 3 months ago by sschmitz
Modified:
8 years, 3 months ago
Reviewers:
xiyuan, mazda
CC:
chromium-reviews, pam+watch_chromium.org, arv (Not doing code reviews), stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, oshima+watch_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

F4 behavior was change to maximize (from fullscreen). The label text needs to be changed, too. Note from mazda@ keyboard_overlay_data.js is generated by tools/gen_keyboard_overaly_data/gen_keyboard_overlay_data.py Necessary changes are: 1. Replace 'full screen' with 'maximize' in gen_keyboard_overlay_data.py 2. Replace 'full screen' with 'maximize' in keyboard_overlay.js 3. Regenerate keyboard_overlay_data.js by running gen_keyboard_overlay_data.py However, currently step 3 does not work properly because of some manual changes of data. In this case, I think it's OK just to replace all 'full screen' with 'maximize' in keyboard_overlay_data.js. The key descriptions on the top row of keyboard overlay are currently not translated (might be better to translate though). See also crbug.com/145402. BUG=150785 TEST=Bring up keyboard overlay and observer label for "F4" Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=158084

Patch Set 1 #

Total comments: 1

Patch Set 2 : fix for Alt & Ctrl #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -51 lines) Patch
M chrome/browser/resources/chromeos/keyboard_overlay.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/keyboard_overlay_data.js View 1 48 chunks +49 lines, -49 lines 0 comments Download
M tools/gen_keyboard_overlay_data/gen_keyboard_overlay_data.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
sschmitz
8 years, 3 months ago (2012-09-19 23:47:20 UTC) #1
xiyuan
+mazda I think the change is okay. But could you double check? And I'll rubber ...
8 years, 3 months ago (2012-09-20 00:00:02 UTC) #2
mazda
lgtm Could you also check shortcut descriptions are correctly shown on F4 key when pressing ...
8 years, 3 months ago (2012-09-20 00:06:40 UTC) #3
sschmitz
On 2012/09/20 00:06:40, mazda wrote: > lgtm > > Could you also check shortcut descriptions ...
8 years, 3 months ago (2012-09-20 00:42:22 UTC) #4
mazda
https://codereview.chromium.org/10946043/diff/1/chrome/browser/resources/chromeos/keyboard_overlay_data.js File chrome/browser/resources/chromeos/keyboard_overlay_data.js (right): https://codereview.chromium.org/10946043/diff/1/chrome/browser/resources/chromeos/keyboard_overlay_data.js#newcode15822 chrome/browser/resources/chromeos/keyboard_overlay_data.js:15822: 'full screen<>ALT': 'keyboardOverlaySwapPrimaryMonitor', Please replace these two lines here ...
8 years, 3 months ago (2012-09-20 00:45:24 UTC) #5
sschmitz
Fix for Alt and Ctrl labels per mazda@'s suggestion: chrome/browser/resources/chromeos/keyboard_overlay_data.js:15822: 'full screen<>ALT': 'keyboardOverlaySwapPrimaryMonitor', Please replace ...
8 years, 3 months ago (2012-09-20 17:16:58 UTC) #6
xiyuan
lgtm
8 years, 3 months ago (2012-09-20 17:19:43 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sschmitz@chromium.org/10946043/8001
8 years, 3 months ago (2012-09-20 17:34:45 UTC) #8
commit-bot: I haz the power
Retried try job too often for step(s) sync_integration_tests
8 years, 3 months ago (2012-09-21 02:32:10 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sschmitz@chromium.org/10946043/8001
8 years, 3 months ago (2012-09-21 19:59:33 UTC) #10
commit-bot: I haz the power
8 years, 3 months ago (2012-09-21 21:36:41 UTC) #11
Change committed as 158084

Powered by Google App Engine
This is Rietveld 408576698