Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 10946031: Modifies GetPlatformImageColor() to check the color of a given point. (Closed)

Created:
8 years, 3 months ago by rohitrao (ping after 24h)
Modified:
8 years, 3 months ago
CC:
chromium-reviews, rsesek+watch_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Modifies GetPlatformImageColor() to check the color of a given point. BUG=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=157601

Patch Set 1 #

Patch Set 2 : Fix compile. #

Patch Set 3 : Fix compile. #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -9 lines) Patch
M ui/gfx/image/image_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M ui/gfx/image/image_unittest_util.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/image/image_unittest_util.cc View 1 2 1 chunk +9 lines, -5 lines 1 comment Download
M ui/gfx/image/image_unittest_util_mac.mm View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
rohitrao (ping after 24h)
I want to write some unittests that separately check pixels in the top half and ...
8 years, 3 months ago (2012-09-19 16:38:40 UTC) #1
Robert Sesek
LGTM, though I'm not a Gtk expert.
8 years, 3 months ago (2012-09-19 16:47:41 UTC) #2
Elliot Glaysher
lgtm http://codereview.chromium.org/10946031/diff/6001/ui/gfx/image/image_unittest_util.cc File ui/gfx/image/image_unittest_util.cc (right): http://codereview.chromium.org/10946031/diff/6001/ui/gfx/image/image_unittest_util.cc#newcode147 ui/gfx/image/image_unittest_util.cc:147: guchar* pixel = gdk_pixels + (y * rowstride) ...
8 years, 3 months ago (2012-09-19 17:47:10 UTC) #3
rohitrao (ping after 24h)
Thanks for the reviews!
8 years, 3 months ago (2012-09-19 18:15:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rohitrao@chromium.org/10946031/6001
8 years, 3 months ago (2012-09-19 18:15:44 UTC) #5
commit-bot: I haz the power
8 years, 3 months ago (2012-09-19 20:41:41 UTC) #6
Change committed as 157601

Powered by Google App Engine
This is Rietveld 408576698