Modifies GetPlatformImageColor() to check the color of a given point.

Modifies GetPlatformImageColor() to check the color of a given point.

BUG=None


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=157601

[rohitrao (ping after 24h), 2012-09-19 16:38:40]

I want to write some unittests that separately check pixels in the top half and
bottom half of a test image, so extending GetPlatformImageColor() is a necessary
prerequisite.

Elliot, can you take a look at the GdkPixbuf pixel extraction code?  I basically
copied it from GdkPixbufToImageSkia() in
chrome/browser/ui/libgtk2ui/gtk2_util.cc.

Thanks!

[Robert Sesek, 2012-09-19 16:47:41]

LGTM, though I'm not a Gtk expert.

[Elliot Glaysher, 2012-09-19 17:47:10]

lgtm

http://codereview.chromium.org/10946031/diff/6001/ui/gfx/image/image_unittest...
File ui/gfx/image/image_unittest_util.cc (right):

http://codereview.chromium.org/10946031/diff/6001/ui/gfx/image/image_unittest...
ui/gfx/image/image_unittest_util.cc:147: guchar* pixel = gdk_pixels + (y *
rowstride) + (x * n_channels);
This is probably correct everywhere. (At least you took care of the main gotcha:
rowstride can sometimes != x * n_channels; it's usually rounded up to the
nearest word.

[rohitrao (ping after 24h), 2012-09-19 18:15:43]

Thanks for the reviews!

[commit-bot: I haz the power, 2012-09-19 18:15:44]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rohitrao@chromium.org/10946031/6001

[commit-bot: I haz the power, 2012-09-19 20:41:41]

Change committed as 157601