Remove Chrome's ProgID from filetype associations at uninstall.

chrome/installer/setup/uninstall.cc

Index: chrome/installer/setup/uninstall.cc
diff --git a/chrome/installer/setup/uninstall.cc b/chrome/installer/setup/uninstall.cc
index 209ff786d9f40c42ba3b8f0660fed666e077e168..49420c99f6f7d80501ff822d83c5af33e9d6a926 100644
--- a/chrome/installer/setup/uninstall.cc
+++ b/chrome/installer/setup/uninstall.cc
@@ -749,6 +749,18 @@ bool DeleteChromeRegistrationKeys(BrowserDistribution* dist, HKEY root,
                                      open_command_pred);
   }
 
+  // Delete each filetype association if it references this Chrome.  Don't
+  // delete the whole key since other apps may have stored data there.
+  InstallUtil::ValueEquals prog_id_pred(prog_id);

[gab, 2012/09/19 16:11:16]

|prog_id| here could be suffixed and unsuffixed (based on the
|browser_entry_suffix| parameter). DeleteChromeRegistrationKeys can be called
with no suffix even when the install present is suffixed (see line 1064 in this
file). So that it's technically possible that this would remove registrations
that are there to make a system-level Chrome default for this user when
uninstalling a user-level install for that same user...

It probably makes sense to only do this extra uninstall step iff |remove_all|.

[grt (UTC plus 2), 2012/09/19 19:43:15]

Great catch.  Updated as discussed.

+  for (const wchar_t* const* filetype = &ShellUtil::kFileAssociations[0];

[gab, 2012/09/19 16:11:16]

I feel this is overly complicated to loop through an array, why not
for (int i = 0; ShellUtil::kFileAssociations[i] != NULL; ++i)
as per shell_util.cc:1339 ?

[grt (UTC plus 2), 2012/09/19 19:43:15]

The size of the array isn't known here as it is in shell_util.cc.

[gab, 2012/09/19 19:58:50]

Hmmm, the suggested code doesn't depend on the size of the array...

[grt (UTC plus 2), 2012/09/19 20:04:52]

Oh, I see.  I read the suggestion as knowing arraysize.  Anyway, I like the
iterator approach rather than the indexing approach, so I'm keeping it.  :-)

+       *filetype != NULL; ++filetype) {
+    parent_key.resize(base_length);
+    parent_key.push_back(FilePath::kSeparators[0]);

[gab, 2012/09/19 16:11:16]

If |parent_key| is always going to have the separator, why not make the
separator part of the base section (i.e. adding it before initializing
|base_length|)?

[grt (UTC plus 2), 2012/09/19 19:43:15]

Done.

+    parent_key.append(*filetype);
+    InstallUtil::DeleteRegistryValueIf(root, parent_key.c_str(), L"",

[gab, 2012/09/19 16:11:16]

optional: I don't like that this method takes wchar_t* only to assert they are
not NULL... I would prefer if it would take string16s, but this is beyond the
scope of this CL, so feel free to ignore :).

[grt (UTC plus 2), 2012/09/19 19:43:15]

Ignored.  It's common to call this fn with a literal.  I don't like forcing the
construction of strings when not necessary.

+                                       prog_id_pred);
+  }
+
   // Note that we do not attempt to delete filetype associations since MSDN
   // says "Windows respects the Default value only if the ProgID found there is
   // a registered ProgID. If the ProgID is unregistered, it is ignored."
@@ -1096,6 +1108,10 @@ InstallStatus UninstallProduct(const InstallationState& original_state,
 #if 0
     UninstallActiveSetupEntries(installer_state, product);
 #endif
+
+    // Notify the shell that associations have changed since Chrome was likely
+    // unregistered.
+    SHChangeNotify(SHCNE_ASSOCCHANGED, SHCNF_IDLIST, NULL, NULL);
   }
 
   if (product.is_chrome_frame()) {