[filemanager] Importing progress implemented.

[filemanager] Importing progress implemented.

BUG=135169
TEST=See bug.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=157769

[dgozman, 2012-09-19 11:31:50]

Take a look please.

[Vladislav Kaznacheev, 2012-09-19 12:29:52]

https://codereview.chromium.org/10946029/diff/1/chrome/browser/resources/file...
File chrome/browser/resources/file_manager/js/photo/importing_dialog.js (right):

https://codereview.chromium.org/10946029/diff/1/chrome/browser/resources/file...
chrome/browser/resources/file_manager/js/photo/importing_dialog.js:33:
this.imageBox_ = this.document_.createElement('div');
I suggest using util.createChild here which is much shorter.

https://codereview.chromium.org/10946029/diff/1/chrome/browser/resources/file...
chrome/browser/resources/file_manager/js/photo/importing_dialog.js:151:
console.log('got: ', event.reason);
I forgot to remove this line

https://codereview.chromium.org/10946029/diff/1/chrome/browser/resources/file...
chrome/browser/resources/file_manager/js/photo/importing_dialog.js:187:
console.log('Unknown "copy-progress" event reason: ' + event.reason);
This deserves console.warn or even console.error

https://codereview.chromium.org/10946029/diff/1/chrome/browser/resources/file...
File chrome/browser/resources/file_manager/js/photo/photo_import.js (right):

https://codereview.chromium.org/10946029/diff/1/chrome/browser/resources/file...
chrome/browser/resources/file_manager/js/photo/photo_import.js:134:
this.destination_ = dir;
Not updating UI? Looks strange.

[Vladislav Kaznacheev, 2012-09-19 12:30:30]

https://codereview.chromium.org/10946029/diff/1/chrome/browser/resources/file...
File chrome/browser/resources/file_manager/js/photo/importing_dialog.js (right):

https://codereview.chromium.org/10946029/diff/1/chrome/browser/resources/file...
chrome/browser/resources/file_manager/js/photo/importing_dialog.js:151:
console.log('got: ', event.reason);
I meant YOU forgot:)
On 2012/09/19 12:29:52, Vladislav Kaznacheev wrote:
> I forgot to remove this line

[dgozman, 2012-09-19 13:45:28]

PTAL

https://codereview.chromium.org/10946029/diff/1/chrome/browser/resources/file...
File chrome/browser/resources/file_manager/js/photo/importing_dialog.js (right):

https://codereview.chromium.org/10946029/diff/1/chrome/browser/resources/file...
chrome/browser/resources/file_manager/js/photo/importing_dialog.js:33:
this.imageBox_ = this.document_.createElement('div');
On 2012/09/19 12:29:52, Vladislav Kaznacheev wrote:
> I suggest using util.createChild here which is much shorter.

Done.

https://codereview.chromium.org/10946029/diff/1/chrome/browser/resources/file...
chrome/browser/resources/file_manager/js/photo/importing_dialog.js:151:
console.log('got: ', event.reason);
On 2012/09/19 12:30:30, Vladislav Kaznacheev wrote:
> I meant YOU forgot:)
> On 2012/09/19 12:29:52, Vladislav Kaznacheev wrote:
> > I forgot to remove this line
> 

Done.

https://codereview.chromium.org/10946029/diff/1/chrome/browser/resources/file...
chrome/browser/resources/file_manager/js/photo/importing_dialog.js:187:
console.log('Unknown "copy-progress" event reason: ' + event.reason);
On 2012/09/19 12:29:52, Vladislav Kaznacheev wrote:
> This deserves console.warn or even console.error

Done.

https://codereview.chromium.org/10946029/diff/1/chrome/browser/resources/file...
File chrome/browser/resources/file_manager/js/photo/photo_import.js (right):

https://codereview.chromium.org/10946029/diff/1/chrome/browser/resources/file...
chrome/browser/resources/file_manager/js/photo/photo_import.js:134:
this.destination_ = dir;
On 2012/09/19 12:29:52, Vladislav Kaznacheev wrote:
> Not updating UI? Looks strange.

Nice catch. Fixed.

[Vladislav Kaznacheev, 2012-09-19 15:55:31]

lgtm

[commit-bot: I haz the power, 2012-09-20 11:32:17]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dgozman@chromium.org/10946029/2003

[commit-bot: I haz the power, 2012-09-20 15:26:30]

Change committed as 157769