content/browser/web_contents/render_view_host_manager.cc - Issue 10945042: Add UMA to measure potential impact of Fast Tab Close.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/web_contents/render_view_host_manager.cc

Issue 10945042: Add UMA to measure potential impact of Fast Tab Close. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Forward the "preceed time" from render view host manager. Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/web_contents/render_view_host_manager.cc

diff --git a/content/browser/web_contents/render_view_host_manager.cc b/content/browser/web_contents/render_view_host_manager.cc

index 9118d43012dfffdc24e4a1377a1cdbd920ce667c..508ab238cea53c29a99306228f360c5cc15af5b0 100644

--- a/content/browser/web_contents/render_view_host_manager.cc

+++ b/content/browser/web_contents/render_view_host_manager.cc

@@ -334,7 +334,7 @@ void RenderViewHostManager::ShouldClosePage(

} else {

// Non-cross site transition means closing the entire tab.

bool proceed_to_fire_unload;

- delegate_->BeforeUnloadFiredFromRenderManager(proceed,

+ delegate_->BeforeUnloadFiredFromRenderManager(proceed, proceed_time,

&proceed_to_fire_unload);

if (proceed_to_fire_unload) {