Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Unified Diff: content/browser/web_contents/web_contents_view_aura.cc

Issue 10945037: Remove unused field from WebContentsViewAura and add comment as to why (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/web_contents/web_contents_view_aura.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/web_contents/web_contents_view_aura.cc
diff --git a/content/browser/web_contents/web_contents_view_aura.cc b/content/browser/web_contents/web_contents_view_aura.cc
index 42b2ff26d4249b8808d4ce7d49b8661811acb408..01460c7fd2a3213ad28dea9a3a6d82ee86f68c7c 100644
--- a/content/browser/web_contents/web_contents_view_aura.cc
+++ b/content/browser/web_contents/web_contents_view_aura.cc
@@ -251,7 +251,9 @@ void WebContentsViewAura::EndDrag(WebKit::WebDragOperationsMask ops) {
// WebContentsViewAura, WebContentsView implementation:
void WebContentsViewAura::CreateView(const gfx::Size& initial_size) {
- initial_size_ = initial_size;
+ // NOTE: we ignore |initial_size| since in some cases it's wrong (such as
+ // if the bookmark bar is not shown and you create a new tab). The right
+ // value is set shortly after this, so its safe to ignore.
window_.reset(new aura::Window(this));
window_->set_owned_by_parent(false);
« no previous file with comments | « content/browser/web_contents/web_contents_view_aura.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698